Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new CI job to run validator against k8s master rules - optional #24545

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Add a new CI job to run validator against k8s master rules - optional #24545

merged 1 commit into from
Dec 4, 2021

Conversation

dims
Copy link
Member

@dims dims commented Dec 4, 2021 •
edited
Loading

will help catch problems when we modify validator (example kubernetes/publishing-bot#270)

Signed-off-by: Davanum Srinivas davanum@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 4, 2021
@k8s-ci-robot k8s-ci-robot requested review from mfojtik and sttts December 4, 2021 12:45
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2021
@dims
Add a new CI job to run validator against k8s master rules - optional
9fe2e5a 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the add-new-publishing-bot-ci-job-to-validate-rules-in-k8s branch from 778fd30 to 9fe2e5a Compare December 4, 2021 12:52
xmudrii
xmudrii approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cd7c85c into kubernetes:master Dec 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 4, 2021
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key publishing-bot-presubmits.yaml using file config/jobs/kubernetes/publishing-bot/publishing-bot-presubmits.yaml

In response to this:

will help catch problems when we modify validator (example kubernetes/publishing-bot#270)

Signed-off-by: Davanum Srinivas davanum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@dims @k8s-ci-robot @xmudrii