Introduce the workflow_run events to the githubeventserver
#24548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
|
/cc @cjwagner |
alvaroaleman
reviewed
Dec 7, 2021
| Action string `json:"action"` | ||
| WorkflowRun WorkflowRun `json:"workflow_run"` | ||
| Workflow Workflow `json:"workflow"` | ||
| Repo *Repo `json:"repository"` |
There was a problem hiding this comment.
Why name this differently than in the json?
There was a problem hiding this comment.
We do the same in the rest of the event structs. I just kept the same approach.
alvaroaleman
approved these changes
Dec 7, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, droslean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the
githubeventserverto handleworkflow_runevents/cc @alvaroaleman @stevekuznetsov
Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com