Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Enable all k/publishing-bot presubmits as blocking #24564

Merged
merged 1 commit into from
Dec 7, 2021
Merged

releng: Enable all k/publishing-bot presubmits as blocking #24564

merged 1 commit into from
Dec 7, 2021

Conversation

justaugustus
Copy link
Member

Part of kubernetes/publishing-bot#272.

Specifically, this commit updates the following jobs to blocking:

  • pull-publishing-bot-validate-rules (might've caught this)
  • pull-publishing-bot-image

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @dims @cpanato @puerco
cc: @kubernetes/publishing-bot-maintainers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 7, 2021
@justaugustus justaugustus mentioned this pull request Dec 7, 2021
Closed
6 tasks
@justaugustus
Copy link
Member Author

Ahhh, found another OWNERS that needs updating.
/assign @sttts @nikhita

@justaugustus justaugustus mentioned this pull request Dec 7, 2021
Merged
@justaugustus
Copy link
Member Author

Ahhh, found another OWNERS that needs updating.

Opened #24565 for this.

@justaugustus
Copy link
Member Author

/check-owners

@justaugustus
Copy link
Member Author

/verify-owners

@justaugustus
releng: Enable all k/publishing-bot presubmits as blocking
0df9ed3 
Specifically, this commit updates the following jobs to blocking:
- `pull-publishing-bot-validate-rules`
- `pull-publishing-bot-image`

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@puerco
Copy link
Member

puerco commented Dec 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@ameukam
Copy link
Member

ameukam commented Dec 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit d25ac51 into kubernetes:master Dec 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key publishing-bot-presubmits.yaml using file config/jobs/kubernetes/publishing-bot/publishing-bot-presubmits.yaml

In response to this:

Part of kubernetes/publishing-bot#272.

Specifically, this commit updates the following jobs to blocking:

  • pull-publishing-bot-validate-rules (might've caught this)
  • pull-publishing-bot-image

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @dims @cpanato @puerco
cc: @kubernetes/publishing-bot-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dims dims

@sttts sttts

@ameukam ameukam

@puerco puerco

@cpanato cpanato

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
8 participants
@justaugustus @k8s-ci-robot @puerco @ameukam @dims @sttts @cpanato @nikhita