Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit lifts the 1.23 Code Freeze by removing the milestone rest… #24572

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

reylejano
Copy link
Member

This PR lifts the 1.23 Code Freeze by removing the v1.23 milestone restriction from k/k:master and k/k:release-1.23.

/hold until the release is finish
/milestone v1.23
/sig release
/area release-eng
cc: @kubernetes/release-engineering @kubernetes/release-team

…riction from k/k:master and k/k:release-1.23
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Dec 7, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 7, 2021
@dims
Copy link
Member

dims commented Dec 7, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@palnabarun
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@puerco
Copy link
Member

puerco commented Dec 7, 2021

/lgtm

@reylejano
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit c497035 into kubernetes:master Dec 7, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.23, v1.24 Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

@reylejano: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

This PR lifts the 1.23 Code Freeze by removing the v1.23 milestone restriction from k/k:master and k/k:release-1.23.

/hold until the release is finish
/milestone v1.23
/sig release
/area release-eng
cc: @kubernetes/release-engineering @kubernetes/release-team

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reylejano reylejano deleted the 123-thaw branch December 29, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants