-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig-node: migrate away from GCP project: cri-containerd-node-e2e #24979
sig-node: migrate away from GCP project: cri-containerd-node-e2e #24979
Conversation
Hi @rayandas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@@ -899,7 +900,7 @@ periodics: | |||
- -- | |||
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/containerd/containerd-master/image-config.yaml | |||
- --deployment=node | |||
- --gcp-project=cri-containerd-node-e2e | |||
- --gcp-project= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- --gcp-project= |
@rayandas it's not necessary to keep an empty flag
b54fb6b
to
27bd7aa
Compare
❌ Deploy Preview for kubernetes-prow failed. 🔨 Explore the source changes: 27bd7aa 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-prow/deploys/61f7faf7c7a3160008608fa3 |
/skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, rayandas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rayandas you may need to force push a new commit to get rid of these broken netlify jobs. I can't seem to override them |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
2 similar comments
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/hold @rayandas Can you, please, close this PR and open a new one ? Thank you! |
27bd7aa
to
99b4f83
Compare
Did a rebase and force push. It should work now. |
/hold cancel |
/lgtm |
@rayandas: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR migrates away cri-containerd-node-e2e from GCP project.