kops: test alternative registry for periodics-distros #25155
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
I also would like to extend this to other periodics for kops. cc @justinsb |
ameukam
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -752,6 +752,7 @@ def generate_distros(): | |||
| kops_channel='alpha', | |||
| name_override=f"kops-aws-distro-image{distro}", | |||
| extra_dashboards=['kops-distros'], | |||
| extra_flags=['--set=spec.assets.containerProxy=registry-sandbox.k8s.io'], | |||
There was a problem hiding this comment.
This will require networking='kubenet' to work, as any Calico assets will b missing from sandbox.k8s.io, right?
There was a problem hiding this comment.
The only assets concerned are the kubernetes container images from k8s.gcr.io. PR updated.
There was a problem hiding this comment.
Yes, but this setting affects all assets, not just the k8s.gcr.io ones. Thanks for updating.
There was a problem hiding this comment.
@hakman What's the best approach if I want to extend this change to other periodic jobs ? Is this change enough or do I need to make changes per use ?
There was a problem hiding this comment.
Most jobs use CNIs (as kubenet style networking is not really a production use case). This means that setting this proxy will not work for that case, unless the proxy is made to proxy CNI repos too.
Most likely path is to decide on a final dns name for the CDN cached registry and switch all kOps manifests to use it during the kOps 1.24 development cycle. We can decide later during that cycle if we want to keep it or revert to k8s.gcr.io.
There was a problem hiding this comment.
My pleasure. Thanks for trying to improve this. I think it will become a huge improvement for many k8s users in the future if successful.
Related: - kubernetes/k8s.io#1834 Test different AWS AMI with registry-sandbox.k8s.io Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
ameukam
force-pushed
the
kops-distro-registry-sandbox
branch
from
593e796 to
8abf16c
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@ameukam: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related:
Test different AWS AMI with registry-sandbox.k8s.io
Signed-off-by: Arnaud Meukam ameukam@gmail.com