Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more env vars to preset-pull-registry-sandbox-repo-list #25466

Conversation

dims
Copy link
Member

@dims dims commented Mar 2, 2022

throw more env vars like KUBE_DOCKER_REGISTRY and KUBE_ADDON_REGISTRY so we can test the alternate sandbox proxy/registry

See https://cs.k8s.io/?q=KUBE_(DOCKER%7CADDON)_REGISTRY&i=nope&files=&excludeFiles=&repos=kubernetes/kubernetes on what these values affect

Signed-off-by: Davanum Srinivas davanum@gmail.com

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2022
@dims
Copy link
Member Author

dims commented Mar 2, 2022

/assign @ameukam @BenTheElder

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 2, 2022
@palnabarun
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@ameukam
Copy link
Member

ameukam commented Mar 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1698a1e into kubernetes:master Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 2, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

throw more env vars like KUBE_DOCKER_REGISTRY and KUBE_ADDON_REGISTRY so we can test the alternate sandbox proxy/registry

See https://cs.k8s.io/?q=KUBE_(DOCKER%7CADDON)_REGISTRY&i=nope&files=&excludeFiles=&repos=kubernetes/kubernetes on what these values affect

Signed-off-by: Davanum Srinivas davanum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants