Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to registry.k8s.io from registry-sandbox #25607

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Switch to registry.k8s.io from registry-sandbox #25607

merged 1 commit into from
Mar 12, 2022

Conversation

dims
Copy link
Member

@dims dims commented Mar 11, 2022

registry.k8s.io is now up and running so let's switch to that one.

Signed-off-by: Davanum Srinivas davanum@gmail.com

@dims
Switch to registry.k8s.io from registry-sandbox
5b062fd 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@ameukam
Copy link
Member

ameukam commented Mar 12, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2022
@ameukam
Copy link
Member

ameukam commented Mar 12, 2022

/test pull-test-infra-prow-checkconfig

@k8s-ci-robot k8s-ci-robot merged commit b555995 into kubernetes:master Mar 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 12, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key default-sandbox.yaml using file ``
  • key default.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/registry/default.yaml

In response to this:

registry.k8s.io is now up and running so let's switch to that one.

Signed-off-by: Davanum Srinivas davanum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam mentioned this pull request Mar 14, 2022
Closed
9 tasks
@ameukam
Copy link
Member

ameukam commented Mar 14, 2022

Ref: kubernetes/k8s.io#3411

rajibmitra
rajibmitra reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@rajibmitra rajibmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajibmitra rajibmitra rajibmitra left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @k8s-ci-robot @ameukam @rajibmitra