-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-api: trigger failed GitHub actions via /retest #25736
cluster-api: trigger failed GitHub actions via /retest #25736
Conversation
config/prow/plugins.yaml
Outdated
- repos: | ||
- kubernetes-sigs/cluster-api | ||
join_org_url: "https://git.k8s.io/community/community-membership.md#member" | ||
only_org_members: true | ||
trigger_github_workflows: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have to put this first in the array because the trigger plugin only takes the first config entry which matches the org or org/repo:
test-infra/prow/plugins/config.go
Lines 858 to 870 in 140be8e
func (c *Configuration) TriggerFor(org, repo string) Trigger { | |
orgRepo := fmt.Sprintf("%s/%s", org, repo) | |
for _, tr := range c.Triggers { | |
for _, r := range tr.Repos { | |
if r == org || r == orgRepo { | |
return tr | |
} | |
} | |
} | |
var tr Trigger | |
tr.SetDefaults() | |
return tr | |
} |
/cc @fabriziopandini @CecileRobertMichon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Signed-off-by: Stefan Büringer buringerst@vmware.com
62c7ee8
to
eebc60d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/cc @dims |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, dims, fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer buringerst@vmware.com