Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cherrypicker to cloud-provider-openstack #29596

Merged
merged 1 commit into from
May 26, 2023

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented May 25, 2023

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from cblecker, chases2 and dims May 25, 2023 13:53
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 25, 2023
@mdbooth
Copy link
Contributor Author

mdbooth commented May 25, 2023

@zetaab @jichenjc @kayrus Any reason not to do this?

@kayrus
Copy link

kayrus commented May 25, 2023

Any reason not to do this?

would be nice to know how does it work on the high level. What if the PR contains multiple commits? How to activate it for a specific PR, etc.

@mdbooth
Copy link
Contributor Author

mdbooth commented May 25, 2023

Any reason not to do this?

would be nice to know how does it work on the high level. What if the PR contains multiple commits? How to activate it for a specific PR, etc.

Here's a very simple example of @jichenjc using it in CAPO: kubernetes-sigs/cluster-api-provider-openstack#1492 (comment)

@mdbooth
Copy link
Contributor Author

mdbooth commented May 25, 2023

Here's an example where there was a merge conflict and it couldn't do it automatically: kubernetes-sigs/cluster-api-provider-openstack#1519 (comment)

@mdbooth
Copy link
Contributor Author

mdbooth commented May 25, 2023

Here's a cherry-pick of a PR with 2 commits: kubernetes-sigs/cluster-api-provider-openstack#1426

@kayrus
Copy link

kayrus commented May 25, 2023

cool. LGTM

@zetaab
Copy link
Member

zetaab commented May 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@jichenjc
Copy link
Contributor

/approve

@mdbooth
Copy link
Contributor Author

mdbooth commented May 26, 2023

Looks like we want this feature! Lets see if we can find a friendly approver.

/hold cancel
/assign @dims

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@dims
Copy link
Member

dims commented May 26, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jichenjc, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 835e9a8 into kubernetes:master May 26, 2023
@k8s-ci-robot
Copy link
Contributor

@mdbooth: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth mdbooth deleted the cpo-cherrypicker branch May 26, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants