Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cni plugin for AWS scale tests #29968

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

prateekgogia
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @prateekgogia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 29, 2023
@dims
Copy link
Member

dims commented Jun 29, 2023

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, prateekgogia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@hakman
Copy link
Member

hakman commented Jun 29, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@hakman
Copy link
Member

hakman commented Jun 29, 2023

@prateekgogia @dims Amazon VPC CNI doesn't work with Ubuntu 22.04 (see aws/amazon-vpc-cni-k8s#2103).

I suggest to also add the scale tests with Calico, as we know it's working.

@prateekgogia
Copy link
Contributor Author

@prateekgogia @dims Amazon VPC CNI doesn't work with Ubuntu 22.04 (see aws/amazon-vpc-cni-k8s#2103).

I suggest to also add the scale tests with Calico, as we know it's working.

Will create another follow up PR to change to Ubuntu 20.04, once this PR kubernetes/kops#15557 passes the tests

@hakman
Copy link
Member

hakman commented Jun 29, 2023

/hold cancel
/lgtm cancel

config/jobs/kubernetes/kops/build_jobs.py:1068:0: C0301: Line too long (109/100) (line-too-long)
config/jobs/kubernetes/kops/build_jobs.py:1077:0: C0301: Line too long (109/100) (line-too-long)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot
Copy link
Contributor

@prateekgogia: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-test-infra-gubernator
  • /test pull-test-infra-integration
  • /test pull-test-infra-prow-checkconfig
  • /test pull-test-infra-prow-image-build-test
  • /test pull-test-infra-unit-test
  • /test pull-test-infra-verify-cri-o
  • /test pull-test-infra-verify-lint

The following commands are available to trigger optional jobs:

  • /test pull-test-infra-bazel
  • /test pull-test-infra-prow-checkconfig-loose
  • /test pull-test-infra-unit-test-race-detector-nonblocking

Use /test all to run the following jobs that were automatically triggered:

  • pull-test-infra-gubernator
  • pull-test-infra-prow-checkconfig
  • pull-test-infra-prow-checkconfig-loose
  • pull-test-infra-unit-test
  • pull-test-infra-unit-test-race-detector-nonblocking
  • pull-test-infra-verify-lint

In response to this:

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Arnaud M. <ameukam@gmail.com>
@hakman
Copy link
Member

hakman commented Jun 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2023
@hakman
Copy link
Member

hakman commented Jun 30, 2023

/retest

1 similar comment
@hakman
Copy link
Member

hakman commented Jun 30, 2023

/retest

@hakman
Copy link
Member

hakman commented Jun 30, 2023

/test pull-test-infra-unit-test

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

2 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2ca816f into kubernetes:master Jun 30, 2023
@k8s-ci-robot
Copy link
Contributor

@prateekgogia: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-periodics-distros.yaml using file config/jobs/kubernetes/kops/kops-periodics-distros.yaml
  • key kops-periodics-grid.yaml using file config/jobs/kubernetes/kops/kops-periodics-grid.yaml
  • key kops-periodics-misc2.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc2.yaml
  • key kops-presubmits-distros.yaml using file config/jobs/kubernetes/kops/kops-presubmits-distros.yaml
  • key kops-presubmits-scale.yaml using file config/jobs/kubernetes/kops/kops-presubmits-scale.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants