Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prow/plugins/approve): approving with full config OWNERS controlled #29970

Merged
merged 4 commits into from
Sep 29, 2023
Merged

fix(prow/plugins/approve): approving with full config OWNERS controlled #29970

merged 4 commits into from
Sep 29, 2023

Commits on Jul 17, 2023

  1. fix(prow/plugins/approve): support get approvers when used full config 

    Signed-off-by: wuhuizuo <wuhuizuo@126.com>
    @wuhuizuo
    wuhuizuo committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9dd4dd4 View commit details
    Browse the repository at this point in the history

  2. fix(prow/plugins/approve): fix Approvers.UnapprovedFiles method 

    Signed-off-by: wuhuizuo <wuhuizuo@126.com>
    @wuhuizuo
    wuhuizuo committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    273ac97 View commit details
    Browse the repository at this point in the history

  3. fix(prow/plugins/approve): fix Owners.GetSuggestedApprovers method 

    Signed-off-by: wuhuizuo <wuhuizuo@126.com>
    @wuhuizuo
    wuhuizuo committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6b35632 View commit details
    Browse the repository at this point in the history

  4. fix(prow/repoowners): fix RepoOwners.entriesForFile method 

    `NoParentOwners` should only worked when none people got.

For an example:
```
# file sub/OWNERS
options:
  no_parent_owners: true
filters:
  "\\.yaml":
    approvers: [alice]
```

But only the file `func_test.go` changed in the PR, it should use the parent OWNERS file.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
    @wuhuizuo
    wuhuizuo committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    dcd9b36 View commit details
    Browse the repository at this point in the history