-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remaining containerd-build-* jobs to the community bucket and introduce postsubmit jobs #30025
Migrate remaining containerd-build-* jobs to the community bucket and introduce postsubmit jobs #30025
Conversation
125dae0
to
a5d2494
Compare
/approve |
a5d2494
to
25cd49f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
25cd49f
to
82a3aa2
Compare
/retest |
/cc @SergeyKanzhelev This is ready to be merged. |
/assign @SergeyKanzhelev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few comments on the changes:
Also 2 follow up changes need to be done:
- The default bucket referred in
containerd/containerd
should also be changed. - References to
cri-containerd-staging
in the env files used for deploying VMs with containerd should be changed, else those node-e2e jobs will start failing.
config/jobs/containerd/containerd/containerd-periodic-jobs.yaml
Outdated
Show resolved
Hide resolved
config/jobs/containerd/containerd/containerd-postsubmit-jobs.yaml
Outdated
Show resolved
Hide resolved
Can I get a LGTM? |
82a3aa2
to
5862f0c
Compare
config/jobs/containerd/containerd/containerd-periodic-jobs.yaml
Outdated
Show resolved
Hide resolved
5862f0c
to
8889084
Compare
@upodroid I had one more question here #30025 (comment) |
As I said earlier, we can merge this PR now and I can open a separate one to adjust the containerd env files. I'll open it today for review. We'll have stale builds for containerd for a few hours/days after this is merged depending on how fast PRs are being merged in containerd. |
/lgtm |
@upodroid: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
Follow up to #29986
Part of kubernetes/k8s.io#1469
Part of #29722
Fixes #29995
I did a few changes: