Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode the urlopen output #30763

Merged
merged 1 commit into from
Sep 19, 2023
Merged

decode the urlopen output #30763

merged 1 commit into from
Sep 19, 2023

Conversation

rphillips
Copy link
Member

@rphillips rphillips commented Sep 19, 2023 •
edited
Loading

#30759 reported an issue with the image bump. This PR decodes the metadata bytes to a string.

There could be more code locations this impacts; reverting #30695 might make sense.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jenkins sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 19, 2023
@liggitt
Copy link
Member

liggitt commented Sep 19, 2023

do we know what changed today that made this necessary?

@liggitt
Copy link
Member

liggitt commented Sep 19, 2023

#30695 only merged last week. pull-kubernetes-e2e-gce is still using kubekins-e2e:v20230727-ea685f8747-... ... is it still impacted by the bootstrap changed merged to test-infra last week?

@BenTheElder
Copy link
Member

The referenced PR is dockerfile only and should've been possible to roll back purely with image tags.

The python scripts / test-infra are cloned by bootstrap.py jobs and run the latest scripts (that mess being of the many reasons these were deprecated in favor of decorate: true).

@liggitt
Copy link
Member

liggitt commented Sep 19, 2023

oooookay, I'll defer review/approve of this to someone who understands the layering and where this goes and gets called better

BenTheElder
BenTheElder reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 67a1653 into kubernetes:master Sep 19, 2023
@BenTheElder BenTheElder mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@cjwagner cjwagner Awaiting requested review from cjwagner

@mpherman2 mpherman2 Awaiting requested review from mpherman2

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jenkins cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rphillips @liggitt @BenTheElder @k8s-ci-robot