-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit file changing imageStore selinux label to splitfs test #32820
Conversation
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
Hi @bitoku. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm /assign @SergeyKanzhelev @haircommander @haircommander I didn’t know we need the same label for the image store as we need for graph root. I wonder if this is intentional.. |
/approve this makes sense to me as we'll need to do similar things to both paths. I'd imagine image store could get away with a slightly different profile but functionally having the same is secure enough i think |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a unit file to change the selinux label of imageStore in order to fix the test failures in
kubernetes/kubernetes#125417
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/125417/pull-crio-cgroupv2-splitfs-splitdisk/1800694672788557824
Also it modifies the graphroot and runroot to the default.
In the test, all containers failed with exitCode 127, which normally succeed without any errors.
Having tested on the remote e2e, I found that the containers failed with the error like
It turned out to be caused by selinux label mismatch.
Since we split imageStore and graphRoot path, imageStore also must have the same selinux label as graphRoot.
cf. https://github.com/containers/podman/blob/main/troubleshooting.md#11-changing-the-location-of-the-graphroot-leads-to-permission-denied.
I tested this ignition file by running remote e2e with kubernetes/kubernetes#125417 this change, and it passed the tests.