Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit file changing imageStore selinux label to splitfs test #32820

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Jun 23, 2024

This PR adds a unit file to change the selinux label of imageStore in order to fix the test failures in
kubernetes/kubernetes#125417
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/125417/pull-crio-cgroupv2-splitfs-splitdisk/1800694672788557824
Also it modifies the graphroot and runroot to the default.


In the test, all containers failed with exitCode 127, which normally succeed without any errors.
Having tested on the remote e2e, I found that the containers failed with the error like

error while loading shared libraries: /lib64/libc.so.6: cannot apply additional memory protection after relocation: Permission denied

It turned out to be caused by selinux label mismatch.
Since we split imageStore and graphRoot path, imageStore also must have the same selinux label as graphRoot.

cf. https://github.com/containers/podman/blob/main/troubleshooting.md#11-changing-the-location-of-the-graphroot-leads-to-permission-denied.

I tested this ignition file by running remote e2e with kubernetes/kubernetes#125417 this change, and it passed the tests.

Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bitoku. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and endocrimes June 23, 2024 18:34
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 23, 2024
@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2024
@kannon92
Copy link
Contributor

/lgtm

/assign @SergeyKanzhelev @haircommander

@haircommander I didn’t know we need the same label for the image store as we need for graph root. I wonder if this is intentional..

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@haircommander
Copy link
Contributor

/approve

this makes sense to me as we'll need to do similar things to both paths. I'd imagine image store could get away with a slightly different profile but functionally having the same is secure enough i think

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit d0001fc into kubernetes:master Jun 24, 2024
5 of 6 checks passed
@kwilczynski
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants