Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate ci-kubernetes-e2e-gci-gce-flaky #33063

Merged
merged 1 commit into from
Jul 22, 2024
Merged

migrate ci-kubernetes-e2e-gci-gce-flaky #33063

merged 1 commit into from
Jul 22, 2024

Conversation

BenTheElder
Copy link
Member

Found this while inspecting the updates in #33062

We have other comparable jobs in this group migrated already (like ci-kubernetes-e2e-gci-gce-flaky-repro), this should just work ™️

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2024
@BenTheElder BenTheElder mentioned this pull request Jul 22, 2024
Merged
BenTheElder
BenTheElder commented Jul 22, 2024
View reviewed changes
config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
@@ -906,6 +907,13 @@ periodics:
- --test_args=--ginkgo.focus=\[Flaky\] --ginkgo.skip=\[Driver:.gcepd\]|\[Feature:.+\] --minStartupPods=8
- --timeout=180m
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240705-131cd74733-master
resources:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(copied from the -flak-reboot job, we can iterate)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fb4a256 into kubernetes:master Jul 22, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

Found this while inspecting the updates in #33062

We have other comparable jobs in this group migrated already (like ci-kubernetes-e2e-gci-gce-flaky-repro), this should just work ™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the flaky-prow branch July 22, 2024 23:39
@BenTheElder
Copy link
Member Author

failing, but due to failing test cases https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-flaky/1815634399878713344

(and this is running tests tagged as flaky)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @michelle192837