Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sig-testing: uses LABEL_FILTER instead of FOCUS" #33131

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

BenTheElder
Copy link
Member

This reverts commit 6f35659.

We need to test changes like this before rolling them out to presubmit and when merging major changes to presubmit we need to verify that they're working as intended following the merge.

I'm pretty sure this is the root cause for kubernetes/kubernetes#126401

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 26, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Jul 26, 2024

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 26, 2024
@dims
Copy link
Member

dims commented Jul 26, 2024

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 26, 2024
@dims
Copy link
Member

dims commented Jul 26, 2024

cc @carlory @pacoxu

@k8s-ci-robot k8s-ci-robot merged commit cb0886d into kubernetes:master Jul 26, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-kind.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml

In response to this:

This reverts commit 6f35659.

We need to test changes like this before rolling them out to presubmit and when merging major changes to presubmit we need to verify that they're working as intended following the merge.

I'm pretty sure this is the root cause for kubernetes/kubernetes#126401

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the revert-filter branch July 27, 2024 00:02
@BenTheElder
Copy link
Member Author

we'll see in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126345/pull-kubernetes-e2e-kind/1816987117226561536

It will take a bit to know because building Kubernetes takes a 5-10m easily, will check back shortly

@BenTheElder
Copy link
Member Author

We appear to be running tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants