-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "sig-testing: uses LABEL_FILTER instead of FOCUS" #33131
Conversation
This reverts commit 6f35659.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority critical-urgent |
/kind failing-test |
@BenTheElder: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
we'll see in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126345/pull-kubernetes-e2e-kind/1816987117226561536 It will take a bit to know because building Kubernetes takes a 5-10m easily, will check back shortly |
We appear to be running tests now. |
This reverts commit 6f35659.
We need to test changes like this before rolling them out to presubmit and when merging major changes to presubmit we need to verify that they're working as intended following the merge.
I'm pretty sure this is the root cause for kubernetes/kubernetes#126401