Skip to content

Switch publishing-bot CI jobs to use golang:1.24 #34411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Switch publishing-bot CI jobs to use golang:1.24 #34411

merged 1 commit into from
Feb 25, 2025

Conversation

dims
Copy link
Member

@dims dims commented Feb 25, 2025

@dims
Switch publishing-bot CI jobs to use golang:1.24
3c351d9 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 25, 2025
@dims
Copy link
Member Author

dims commented Feb 25, 2025

/assign @BenTheElder @aojea @cpanato

@BenTheElder
Copy link
Member

Can we make this start respecting GOTOOLCHAIN from k/k so we don't have to block on another multi-repo bump?

BenTheElder
BenTheElder reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member 

 - run
      - -mod=mod
      - k8s.io/publishing-bot/cmd/validate-rules
      - /home/prow/go/src/k8s.io/kubernetes/staging/publishing/rules.yaml
      command:
      - go

Let's move this to a script and have it pull the go env setup from hack/lib/golang.sh?

@dims
Copy link
Member Author

dims commented Feb 25, 2025 

 - run
      - -mod=mod
      - k8s.io/publishing-bot/cmd/validate-rules
      - /home/prow/go/src/k8s.io/kubernetes/staging/publishing/rules.yaml
      command:
      - go

Let's move this to a script and have it pull the go env setup from hack/lib/golang.sh?

@akhilerm can you please do this as a follow up?

good call @BenTheElder

@k8s-ci-robot k8s-ci-robot merged commit fbe66d8 into kubernetes:master Feb 25, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key publishing-bot-presubmits.yaml using file config/jobs/kubernetes/publishing-bot/publishing-bot-presubmits.yaml

In response to this:

Needed for kubernetes/kubernetes#129688

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akhilerm
Copy link
Member

@akhilerm can you please do this as a follow up?

Yep. Will do the changes @dims

@BenTheElder
Copy link
Member

See also: kubernetes/kubernetes#130453 for a similar change to centralize updating the go version

@BenTheElder BenTheElder mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@Verolop Verolop Awaiting requested review from Verolop

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@BenTheElder BenTheElder

@cpanato cpanato

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dims @BenTheElder @k8s-ci-robot @akhilerm @cpanato @aojea