Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce etcd unit and integration tests jobs for ppc64le architecture #34543

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Introduce etcd unit and integration tests jobs for ppc64le architecture #34543

merged 1 commit into from
Mar 21, 2025

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented Mar 19, 2025 •
edited
Loading

Add prow job configurations to run integration and unit tests periodically against the main branch on the k8s-infra-ppc64le-prow-build cluster.

The e2e tests on the ppc64le architecture was added through: #34503

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 19, 2025
@kishen-v kishen-v changed the title Introduce etcd unit and integration tests jobs for ppc64le architecture. Introduce etcd unit and integration tests jobs for ppc64le architecture Mar 19, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahrtr and wenjiaswe March 19, 2025 06:43
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 19, 2025
@ivanvc
Copy link
Member

ivanvc commented Mar 19, 2025

/cc @ahrtr @serathius

Slack thread: https://kubernetes.slack.com/archives/C3HD8ARJ5/p1742368433514409

@k8s-ci-robot k8s-ci-robot requested a review from serathius March 19, 2025 18:37
ahrtr
ahrtr reviewed Mar 19, 2025
View reviewed changes
config/jobs/etcd/etcd-periodics.yaml
@@ -467,6 +498,38 @@ periodics:
cpu: "2"
memory: "3Gi"

- name: ci-etcd-integration-1-cpu-ppc64le
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should we add nodeSelector? I see some job have it, but some not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahrtr, currently, the k8s-infra-ppc64le-prow-build cluster consists of ppc64le nodes only. I've removed the nodeSelector section for uniformity for the jobs that run on k8s-infra-ppc64le-prow-build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the clarification.

@ahrtr
Copy link
Member

ahrtr commented Mar 20, 2025

/lgtm
/approve

/hold for other maintainers to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, kishen-v

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@wenjiaswe
Copy link

cc @BenTheElder

@BenTheElder
Copy link
Member

[discussed in sig-etcd meeting, deferring to etcd maintainers but there are no concerns from a test-infra perspective, this only costs us pulling the images on the other budgets and I think having periodic release signal for platforms you support is good]

@mkumatag
Copy link
Member

@ahrtr can you please tag the person who is missing here?

/hold for other maintainers to review

@ivanvc
Copy link
Member

ivanvc commented Mar 21, 2025

@ahrtr can you please tag the person who is missing here?

/cc @jmhbnz @serathius @fuweid

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz March 21, 2025 03:56
@k8s-ci-robot
Copy link
Contributor

@ivanvc: GitHub didn't allow me to request PR reviews from the following users: fuweid.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@ahrtr can you please tag the person who is missing here?

/cc @jmhbnz @serathius @fuweid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Contributor

/lgtm

@mkumatag
Copy link
Member

I see 4/5 approvals have been acked this PR, hence removing the hold.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit a4eb2c0 into kubernetes:master Mar 21, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@kishen-v: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-periodics.yaml using file config/jobs/etcd/etcd-periodics.yaml

In response to this:

Add prow job configurations to run integration and unit tests periodically against the main branch on the k8s-infra-ppc64le-prow-build cluster.

The e2e tests on the ppc64le architecture was added through: #34503

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mkumatag
Copy link
Member

I see all the four tests ran and passed successfully, thanks @kishen-v
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr left review comments

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

@serathius serathius Awaiting requested review from serathius

@jmhbnz jmhbnz Awaiting requested review from jmhbnz

Assignees

@serathius serathius

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kishen-v @ivanvc @ahrtr @k8s-ci-robot @wenjiaswe @BenTheElder @mkumatag @serathius