-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Updating 1.34 jobs #35277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating 1.34 jobs #35277
Conversation
|
@drewhagen: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-managers. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: drewhagen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Probably it's just a matter of merging prev. PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we generate this since we commented out 1.30 from the config (was stable4)
|
/retest-required |
|
@drewhagen: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| if [[ "${GOARCH:-}" == "" ]]; then | ||
| HOST_ARCH=$(go env GOARCH) | ||
| else | ||
| HOST_ARCH="${GOARCH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix I added because it fixes an unbound variable error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❯ GOARCH=arm64 GOOS=darwin make -C releng prepare-release-branch
/Users/drewhagen/Repositories/test-infra/releng/../hack/run-in-python-container.sh pip3 install -r requirements3.txt
Requirement already satisfied: astroid==2.3.3 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 1)) (2.3.3)
Requirement already satisfied: backports.functools_lru_cache==1.6.1 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 2)) (1.6.1)
Requirement already satisfied: configparser==4.0.2 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 3)) (4.0.2)
Requirement already satisfied: chardet==4.0.0 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 4)) (4.0.0)
Requirement already satisfied: isort==4.3.21 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 5)) (4.3.21)
Requirement already satisfied: Jinja2==3.1.5 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 6)) (3.1.5)
Requirement already satisfied: pylint==2.4.4 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 7)) (2.4.4)
Requirement already satisfied: parameterized==0.7.4 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 8)) (0.7.4)
Requirement already satisfied: PyYAML==5.3 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 9)) (5.3)
Requirement already satisfied: requests==2.28.1 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 10)) (2.28.1)
Requirement already satisfied: ruamel.yaml==0.16.5 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 11)) (0.16.5)
Requirement already satisfied: setuptools==44.0.0 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 12)) (44.0.0)
Requirement already satisfied: sh==1.12.14 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 13)) (1.12.14)
Requirement already satisfied: singledispatch==3.4.0.3 in ./.python_virtual_env/lib/python3.9/site-packages (from -r requirements3.txt (line 14)) (3.4.0.3)
Requirement already satisfied: wrapt==1.11.* in ./.python_virtual_env/lib/python3.9/site-packages (from astroid==2.3.3->-r requirements3.txt (line 1)) (1.11.2)
Requirement already satisfied: six~=1.12 in ./.python_virtual_env/lib/python3.9/site-packages (from astroid==2.3.3->-r requirements3.txt (line 1)) (1.17.0)
Requirement already satisfied: lazy-object-proxy==1.4.* in ./.python_virtual_env/lib/python3.9/site-packages (from astroid==2.3.3->-r requirements3.txt (line 1)) (1.4.3)
Requirement already satisfied: MarkupSafe>=2.0 in ./.python_virtual_env/lib/python3.9/site-packages (from Jinja2==3.1.5->-r requirements3.txt (line 6)) (3.0.2)
Requirement already satisfied: mccabe<0.7,>=0.6 in ./.python_virtual_env/lib/python3.9/site-packages (from pylint==2.4.4->-r requirements3.txt (line 7)) (0.6.1)
Requirement already satisfied: certifi>=2017.4.17 in ./.python_virtual_env/lib/python3.9/site-packages (from requests==2.28.1->-r requirements3.txt (line 10)) (2025.8.3)
Requirement already satisfied: charset-normalizer<3,>=2 in ./.python_virtual_env/lib/python3.9/site-packages (from requests==2.28.1->-r requirements3.txt (line 10)) (2.1.1)
Requirement already satisfied: idna<4,>=2.5 in ./.python_virtual_env/lib/python3.9/site-packages (from requests==2.28.1->-r requirements3.txt (line 10)) (3.10)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in ./.python_virtual_env/lib/python3.9/site-packages (from requests==2.28.1->-r requirements3.txt (line 10)) (1.26.20)
[notice] A new release of pip is available: 23.0.1 -> 25.2
[notice] To update, run: pip install --upgrade pip
./run.sh
./run.sh: line 28: HOST_ARCH: unbound variable
make: *** [prepare-release-branch] Error 1
|
@drewhagen @mbianchidev I think we can close this |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Updated the jobs for the 1.34 rc (kubernetes/sig-release#2826).
This should not be merged in until #35275 is merged.
/cc @kubernetes/release-managers @mbianchidev