Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort on timeout, to get stack traces. #6846

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Abort on timeout, to get stack traces. #6846

merged 1 commit into from
Feb 15, 2018

Conversation

porridge
Copy link
Member

A step towards debugging onsi/ginkgo#206
/cc @shyamjvs @ixdy

@porridge porridge requested a review from krzyzacy as a code owner February 15, 2018 11:11
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 15, 2018
@shyamjvs
Copy link
Member

/lgtm
/hold
(I'd prefer if someone from test-infra also takes a look)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2018
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2018
@krzyzacy
Copy link
Member

we don't want kubetest to explode, as after running the e2e test kubetest still needs to clean up clusters, etc

@krzyzacy
Copy link
Member

/assign

@porridge
Copy link
Member Author

porridge commented Feb 15, 2018 via email

@krzyzacy
Copy link
Member

ah, sorry, read it wrong, this should be fine.
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, porridge, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit ffd664e into kubernetes:master Feb 15, 2018
@ixdy ixdy mentioned this pull request Feb 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@ixdy ixdy Awaiting requested review from ixdy

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@krzyzacy krzyzacy

@shyamjvs shyamjvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@porridge @shyamjvs @krzyzacy @k8s-ci-robot @BenTheElder