-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cherry picking functionality over to Prow #7345
Move cherry picking functionality over to Prow #7345
Conversation
It'll need those, we'll want to fix up the build to look like the needs-rebase and add it to the deployment bundle. I think those can be other PR(s) though. /cc @Kargakis |
needs a |
Please, leave a breadcrumb in experimenta;/cherrypicker that points to the new location. |
@@ -0,0 +1 @@ | |||
This project has moved to [https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/cherrypicker](https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/cherrypicker) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kargakis Is this okay for the breadcrumb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, thanks
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jennybuckley, kargakis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#7332
Moves experiment/cherrypicker under prow/external-plugins as suggested in #7332 (comment)
Is this really enough to get it running in k/k though?
I think it also needs a deployment and service, etc, like external-plugins/needs-rebase has.