Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cherry picking functionality over to Prow #7345

Merged
merged 3 commits into from
Mar 22, 2018

Conversation

jennybuckley
Copy link

#7332

Moves experiment/cherrypicker under prow/external-plugins as suggested in #7332 (comment)

Is this really enough to get it running in k/k though?
I think it also needs a deployment and service, etc, like external-plugins/needs-rebase has.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2018
@BenTheElder
Copy link
Member

I think it also needs a deployment and service, etc, like external-plugins/needs-rebase has.

It'll need those, we'll want to fix up the build to look like the needs-rebase and add it to the deployment bundle. I think those can be other PR(s) though.

/cc @Kargakis

@BenTheElder
Copy link
Member

needs a hack/update-bazel.sh to update the build.

@0xmichalis
Copy link
Contributor

Please, leave a breadcrumb in experimenta;/cherrypicker that points to the new location.

@@ -0,0 +1 @@
This project has moved to [https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/cherrypicker](https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/cherrypicker)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kargakis Is this okay for the breadcrumb?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, thanks

@0xmichalis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2018
@0xmichalis 0xmichalis added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jennybuckley, kargakis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants