Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubeadm-DinD-Cluster based kubetest deployer for IPv6 CI #7529

Merged
merged 1 commit into from
Oct 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kubetest/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ go_library(
"//kubetest/conformance:go_default_library",
"//kubetest/dind:go_default_library",
"//kubetest/e2e:go_default_library",
"//kubetest/kubeadmdind:go_default_library",
"//kubetest/process:go_default_library",
"//kubetest/util:go_default_library",
"//vendor/github.com/aws/aws-sdk-go/aws:go_default_library",
Expand Down Expand Up @@ -74,6 +75,7 @@ filegroup(
"//kubetest/conformance:all-srcs",
"//kubetest/dind:all-srcs",
"//kubetest/e2e:all-srcs",
"//kubetest/kubeadmdind:all-srcs",
"//kubetest/process:all-srcs",
"//kubetest/util:all-srcs",
],
Expand Down
30 changes: 30 additions & 0 deletions kubetest/kubeadmdind/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add an OWNERS file for kubeadmdind

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krzyzacy - Whom should I list as reviewers/approvers, and do we need labels in the OWNERS file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no labels are needed, and I would put yourself & people from your project as reviewers/approvers (don't need to put test-infra people here since we are already top-level approvers)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add, thanks.


go_library(
name = "go_default_library",
srcs = ["kubeadm_dind.go"],
importpath = "k8s.io/test-infra/kubetest/kubeadmdind",
visibility = ["//visibility:public"],
deps = ["//kubetest/process:go_default_library"],
)

filegroup(
name = "package-srcs",
srcs = glob(["**"]),
tags = ["automanaged"],
visibility = ["//visibility:private"],
)

filegroup(
name = "all-srcs",
srcs = [":package-srcs"],
tags = ["automanaged"],
visibility = ["//visibility:public"],
)

go_test(
name = "go_default_test",
srcs = ["kubeadm_dind_test.go"],
embed = [":go_default_library"],
deps = ["//kubetest/process:go_default_library"],
)
8 changes: 8 additions & 0 deletions kubetest/kubeadmdind/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
approvers:
- leblancd
- pmichali
- rpothier
reviewers:
- leblancd
- pmichali
- rpothier
Loading