Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom subnet for kubemark-500 and gce-100 scalability jobs #7555

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Use custom subnet for kubemark-500 and gce-100 scalability jobs #7555

merged 1 commit into from
Apr 4, 2018

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Apr 4, 2018

To solve the problem with exhausting subnets quota after introduction of scalability presubmits in #7547

/cc @krzyzacy @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2018
BenTheElder
BenTheElder approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Apr 4, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy,shyamjvs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9622185 into kubernetes:master Apr 4, 2018
@shyamjvs shyamjvs deleted the custom-subnets-for-scale-presubmits branch April 4, 2018 21:32
@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Ref umbrella - #4445

This was referenced Apr 4, 2018
Merged
Closed
@krzyzacy
Copy link
Member

krzyzacy commented Apr 6, 2018 

W0406 00:11:44.227] Trying to find master named 'e2e-big-master'
W0406 00:11:44.227] Looking for address 'e2e-big-master-ip'
I0406 00:11:44.327] IP aliases are enabled. Creating subnetworks.
I0406 00:11:44.328] \033[0;31mSubnetwork e2e-big:e2e-big-custom-subnet does not exist\033[0m

I think http://k8s-testgrid.appspot.com/sig-scalability-gce#gce is busted because of the change? @shyamjvs

@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 6, 2018

Yes, I'm aware of that. I sent out kubernetes/kubernetes#62172 to fix. But seems like there's some more bug which is still causing failures. Looking now...

@shyamjvs
Copy link
Member Author

Ref kubernetes/kubernetes#62267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shyamjvs @krzyzacy @k8s-ci-robot @BenTheElder