Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchup kettle readme, add docs/oss-oncall-log.md #8801

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 24, 2018

Instead of dropping nits in another PR, I'm suggesting via my own

  • Trim kettle's readme down
  • Move restarting instructions into kettle's readme
  • Add known issues section to kettle's readme, link to root cause issue
  • Add docs/oss-oncall-log.md as an attempt to try logging a tl;dr
    of oss oncall issues we've had to deal with

/area kettle
/cc @AishSundar @mithrav

@spiffxp spiffxp requested a review from rmmh as a code owner July 24, 2018 00:36
@k8s-ci-robot k8s-ci-robot added area/kettle approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 24, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Jul 24, 2018


"Oh yeah, I remember having to deal with that a while back... what was it again?"

- Issue: https://github.com/kubernetes/test-infra/issues/8703
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just linking the issue here, can we give it a more descriptive link text eg: Velodrome is out-of-date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like that's additional friction to what (after some thinking overnight) I am concerned is too manual a way to flag issues, but yeah let's give it a shot.

@AishSundar
Copy link
Contributor

minor nit, otherwise lgtm. Feel free to remove hold anytime.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2018
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 24, 2018
kettle/README.md Outdated

```sh
make get-cluster-credentials
kubectl logs $(kubectl get pods -o jsonpath='{.items[?(@.metadata.labels.app=="kettle")].metadata.name}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl logs -l app=kettle works

kettle/README.md Outdated
#### Replace pods

```sh
kubectl delete pod/$( kubectl get pods -o jsonpath='{.items[?(@.metadata.labels.app=="kettle")].metadata.name}' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl delete -l app=kettle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this should be kubectl delete pods -l app=kettle

kettle/README.md Outdated

If deployment.yaml changes, run 'make push deploy'.
- Occasionally data from Kettle stops updating, we suspect this is due to the pod running out of disk space ([#8800](https://github.com/kubernetes/test-infra/issues/8800)). If this happens, [restart kettle](#restarting)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not running out of disk space-- we suspect this is from a transient hang when contacting GCS.

kettle/README.md Outdated
You can watch the pod startup and collect data from various GCS buckets by looking at its logs

```sh
kubectl logs $(kubectl get pods -o jsonpath='{.items[?(@.metadata.labels.app=="kettle")].metadata.name}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl logs -f $(kubectl get pod -l app=kettle -oname)

kettle/README.md Outdated

buckets.yaml is automatically fetched from GitHub.
It might take a couple of hours to be fully functional and start updating BigQuery. You can always go back to [Gubernator BigQuery page](https://bigquery.cloud.google.com/table/k8s-gubernator:build.all?pli=1&tab=details) and check to see if data collection has resumed. Backfill should happen automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"back to the"

- k8s-gubernator BigQuery table is out of date
- Remediation:
- Kettle froze and needed to be restarted
- See [Kettle's README](/kettle/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note to this firing under symptoms

Instead of dropping nits in another PR, I'm suggesting via my own

- Trim kettle's readme down
- Move restarting instructions into kettle's readme
- Add known issues section to kettle's readme, link to root cause issue
- Add docs/oss-oncall-log.md as an attempt to try logging a tl;dr
  of oss oncall issues we've had to deal with
- Incorpoorates review feedback
@spiffxp spiffxp force-pushed the touchup-kettle-troubleshooting branch from 2940dbe to b725738 Compare July 24, 2018 18:24
@rmmh
Copy link
Contributor

rmmh commented Jul 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AishSundar, rmmh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Jul 25, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit fac55c0 into kubernetes:master Jul 25, 2018
@spiffxp spiffxp deleted the touchup-kettle-troubleshooting branch July 25, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants