Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply label_sync to all managed kubernetes orgs #9054

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 15, 2018

I'd like to turn on label_sync for all kubernetes github orgs that are
actively in use

The repos in kubernetes-csi already use automation that depends on these labels

Some repos in kubernetes-incubator do

I would like to move kubernetes-client to have the same level of automation that
kubernetes-sigs does

WDYT?

/hold
for comment and consensusx

/sig contributor-experience
/area github-management

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2018
@k8s-ci-robot k8s-ci-robot added the area/label_sync Issues or PRs related to code in /label_sync label Aug 15, 2018
@cblecker
Copy link
Member

/lgtm

Needs consensus. I'm okay with 72 hours. Please send to k-dev :)
Label all the things!! 🗒

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Aug 15, 2018

kubernetes-dev@ thread

@cblecker
Copy link
Member

@spiffxp 🕒

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cancel hold?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Aug 21, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 64c3fa0 into kubernetes:master Aug 21, 2018
@spiffxp spiffxp deleted the label-sync-all-the-orgs branch August 21, 2018 02:03
@spiffxp
Copy link
Member Author

spiffxp commented Aug 22, 2018

... right, merging this PR doesn't actually cause the cronjob to get updated, that's something I get to do manually

I'm going to run a job while I'm at it

@spiffxp
Copy link
Member Author

spiffxp commented Aug 22, 2018

Fun facts I had to manually work around:

  • kubernetes-incubator/metrics-server had two identical labels named "cncf-cla: yes", on the same issues. I manually removed one of the labels.
  • kubernetes/website had a manually added triage/pr-requested label with a label description that was exactly one character too long, and caused label_sync to die. I removed the trailing period from its description

@spiffxp
Copy link
Member Author

spiffxp commented Aug 22, 2018

local dry run logs

Running the job

spiffxp@spiffxp-macbookpro:label_sync (add-k-utils-automation)$ make label_sync-job
gcloud container clusters get-credentials "prow" --project="k8s-prow" --zone="us-central1-f"
Fetching cluster endpoint and auth data.
kubeconfig entry generated for prow.
kubectl apply -f cluster/label_sync_job.yaml
job "label-sync" created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants