Enable merge blocking issues for Tide. #9063
Conversation
k8s-ci-robot
added
area/prow
k8s-ci-robot
added
the
approved
|
/this-is-fine |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, krzyzacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@cjwagner: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -340,6 +340,7 @@ tide: | |||
| kubernetes-sigs/cluster-api-provider-openstack: squash | |||
| kubernetes-incubator/service-catalog: squash | |||
| target_url: https://prow.k8s.io/tide.html | |||
| blocker_label: merge-blocker | |||
There was a problem hiding this comment.
where must this label exist? who has privileges to apply it? ok I followed some links and see this will be driven by a plugin
does it need to be added to label_sync
There was a problem hiding this comment.
currently though those with write access to the repo, it will be picked up on any issues on a repo under tide, and will block merges to that repo.
also more magically it will block to a specific branch if you put blah branch: foo-branch in the issue title. >.>
Retry of #9031 now that the issue search bug has been fixed (#9042) and deployed.
I tested this out in dry run mode without a blocking issue and didn't run into any problems so hopefully this won't jam Tide this time.
/area prow
/assign @fejta