Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up 1.8 presubmit jobs #9077

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Conversation

krzyzacy
Copy link
Member

/assign @cjwagner @amwat

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2018
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

It looks like there is still one open PR for the release-1.8 branch: kubernetes/kubernetes#67267

Should we wait to merge this so that PR can still pass presubmits?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krzyzacy
Copy link
Member Author

commented there, I think we won't cut more 1.8 releases so that PR won't matter for 1.8 branch. I'll wait for a little bit.

@krzyzacy
Copy link
Member Author

closed that PR :-)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit cf1a1fb into kubernetes:master Aug 16, 2018
@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
    • key sig-aws-presubmits.yaml using file config/jobs/kubernetes/sig-aws/sig-aws-presubmits.yaml
  • config configmap using the following files:
    • key config.yaml using file prow/config.yaml

In response to this:

/assign @cjwagner @amwat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants