-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up 1.8 presubmit jobs #9077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
It looks like there is still one open PR for the release-1.8
branch: kubernetes/kubernetes#67267
Should we wait to merge this so that PR can still pass presubmits?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, krzyzacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
commented there, I think we won't cut more 1.8 releases so that PR won't matter for 1.8 branch. I'll wait for a little bit. |
closed that PR :-) /hold cancel |
@krzyzacy: Updated the following 2 configmaps:
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @cjwagner @amwat