Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split gpu jobs to their own configs #9103

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

krzyzacy
Copy link
Member

put them under sig-gcp, not sure if that's sig-gcp or sig-scheduling? from config.json it has both.

Also moved three autoscaling gpu jobs, and made sig lead @DirectXMan12 and @mwielgus approvers for now.

/area jobs
/assign @mindprince @jiayingz @vishh @yguo0905

@k8s-ci-robot k8s-ci-robot added area/jobs area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2018
@rohitagarwal003
Copy link
Member

Thanks Sen.

Can you move the GKE GPU autoscaling jobs to be under sig-gcp as well?

I haven't checked all of them but some of the tests are not moved yet (ci-cri-containerd-e2e-gce-device-plugin-gpu, ci-kubernetes-e2e-gke-staging-latest-device-plugin-gpu and ci-kubernetes-e2e-gke-staging-latest-device-plugin-gpu-v100)

Also, I don't know how many levels of hierarchy is supported but here's what I would like to have:

sig-gcp/gpu/presubmits

  • pull-kubernetes-e2e-gce-device-plugin-gpu
  • pull-kubernetes-e2e-gke-device-plugin-gpu

sig-gcp/gpu/gce

  • ci-kubernetes-e2e-gce-device-plugin-gpu
  • ci-kubernetes-e2e-gce-device-plugin-gpu-beta
  • ci-kubernetes-e2e-gce-device-plugin-gpu-stable1
  • ci-kubernetes-e2e-gce-device-plugin-gpu-stable2
  • ci-kubernetes-e2e-gce-gpu-stable1
  • ci-kubernetes-e2e-gce-gpu-stable2
  • ci-cri-containerd-e2e-gce-device-plugin-gpu

sig-gcp/gpu/gke

  • ci-kubernetes-e2e-gke-device-plugin-gpu
  • ci-kubernetes-e2e-gke-device-plugin-gpu-beta
  • ci-kubernetes-e2e-gke-device-plugin-gpu-stable1
  • ci-kubernetes-e2e-gke-device-plugin-gpu-stable2
  • ci-kubernetes-e2e-gke-device-plugin-gpu-p100
  • ci-kubernetes-e2e-gke-device-plugin-gpu-p100-beta
  • ci-kubernetes-e2e-gke-device-plugin-gpu-p100-stable1
  • ci-kubernetes-e2e-gke-device-plugin-gpu-p100-stable2
  • ci-kubernetes-e2e-gke-staging-latest-device-plugin-gpu
  • ci-kubernetes-e2e-gke-staging-latest-device-plugin-gpu-v100
  • ci-kubernetes-e2e-gke-device-plugin-gpu-monitoring
  • ci-kubernetes-e2e-gke-device-plugin-gpu-ubuntu

sig-gcp/gpu/autoscaling

  • ci-kubernetes-e2e-gci-gke-autoscaling-gpu-k80
  • ci-kubernetes-e2e-gci-gke-autoscaling-gpu-p100
  • ci-kubernetes-e2e-gci-gke-autoscaling-gpu-v100

sig-gcp/gpu/upgrade-downgrade

  • ci-kubernetes-e2e-gce-gpu-stable2-stable1-master-upgrade
  • ci-kubernetes-e2e-gce-gpu-stable2-stable1-cluster-upgrade
  • ci-kubernetes-e2e-gce-gpu-stable1-beta-master-upgrade
  • ci-kubernetes-e2e-gce-gpu-stable1-beta-cluster-upgrade
  • ci-kubernetes-e2e-gce-gpu-stable1-master-master-upgrade
  • ci-kubernetes-e2e-gce-gpu-stable1-master-cluster-upgrade
  • ci-kubernetes-e2e-gce-gpu-beta-stable1-cluster-downgrade
  • ci-kubernetes-e2e-gce-gpu-master-stable1-cluster-downgrade

And then in a separate PR, we can move the testgrid to have these as sub tabs as well.

@krzyzacy
Copy link
Member Author

hummm, ci-cri-containerd-e2e-gce-device-plugin-gpu is under sig-node/containerd, I think that job should stay there?

and I would keep the gke-staging ones under gke given I'll probably move all of them to internal prow soon, wdyt?

@krzyzacy krzyzacy force-pushed the bikeshed-2 branch 3 times, most recently from fec316c to 744d5a5 Compare August 21, 2018 18:33
@rohitagarwal003
Copy link
Member

SGTM for both points.

One minor request: can you rename the files to remove the redundant sig-gcp-gpu- prefix.

Everything else LGTM. (I haven't diffed the actual specs, so hoping there's no copy-paste errors).

@krzyzacy
Copy link
Member Author

@mindprince we use basename of the file as configmap keys... so we need to keep the sig-gcp-gpu part so from prow log we can tell where the config is coming from when debugging

I replaced some quotes and all \\ with \ to properly escape ginkgo args, should be no-op, but if something breaks let me know.

Copy link
Member

@rohitagarwal003 rohitagarwal003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, mindprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1985145 into kubernetes:master Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
    • key sig-gcp-gpu-autoscaling.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-autoscaling.yaml
    • key sig-gcp-gpu-gce.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-gce.yaml
    • key sig-gcp-gpu-gke.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-gke.yaml
    • key sig-gcp-gpu-presubmit.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-presubmit.yaml
    • key sig-gcp-gpu-upgrade-downgrade.yaml using file config/jobs/kubernetes/sig-gcp/gpu/sig-gcp-gpu-upgrade-downgrade.yaml
  • config configmap using the following files:
    • key config.yaml using file prow/config.yaml

In response to this:

put them under sig-gcp, not sure if that's sig-gcp or sig-scheduling? from config.json it has both.

Also moved three autoscaling gpu jobs, and made sig lead @DirectXMan12 and @mwielgus approvers for now.

/area jobs
/assign @mindprince @jiayingz @vishh @yguo0905

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants