-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split gpu jobs to their own configs #9103
Conversation
Thanks Sen. Can you move the GKE GPU autoscaling jobs to be under sig-gcp as well? I haven't checked all of them but some of the tests are not moved yet (ci-cri-containerd-e2e-gce-device-plugin-gpu, ci-kubernetes-e2e-gke-staging-latest-device-plugin-gpu and ci-kubernetes-e2e-gke-staging-latest-device-plugin-gpu-v100) Also, I don't know how many levels of hierarchy is supported but here's what I would like to have: sig-gcp/gpu/presubmits
sig-gcp/gpu/gce
sig-gcp/gpu/gke
sig-gcp/gpu/autoscaling
sig-gcp/gpu/upgrade-downgrade
And then in a separate PR, we can move the testgrid to have these as sub tabs as well. |
hummm, and I would keep the gke-staging ones under gke given I'll probably move all of them to internal prow soon, wdyt? |
fec316c
to
744d5a5
Compare
SGTM for both points. One minor request: can you rename the files to remove the redundant Everything else LGTM. (I haven't diffed the actual specs, so hoping there's no copy-paste errors). |
@mindprince we use basename of the file as configmap keys... so we need to keep the sig-gcp-gpu part so from prow log we can tell where the config is coming from when debugging I replaced some quotes and all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, mindprince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@krzyzacy: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
put them under sig-gcp, not sure if that's sig-gcp or sig-scheduling? from config.json it has both.
Also moved three autoscaling gpu jobs, and made sig lead @DirectXMan12 and @mwielgus approvers for now.
/area jobs
/assign @mindprince @jiayingz @vishh @yguo0905