Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct conformance testing instructions #9116

Merged
merged 1 commit into from
Aug 22, 2018
Merged

correct conformance testing instructions #9116

merged 1 commit into from
Aug 22, 2018

Conversation

BenTheElder
Copy link
Member

see: #9104 for context

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2018
@BenTheElder
Copy link
Member Author

The command is a bit unweidly now :(, may rework that to make it more readable
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@BenTheElder
Copy link
Member Author

/hold cancel
moved part of it out to another env :|, at least it's a bit more readable I think

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@BenTheElder
Copy link
Member Author

/assign @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Aug 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

I've also reached out to andrewsykim at digital ocean and rolpat with gardener, dims with openstack already saw the related PR last night AFAIK.

@k8s-ci-robot k8s-ci-robot merged commit d9894e0 into kubernetes:master Aug 22, 2018
@BenTheElder BenTheElder deleted the inigomontoya branch August 22, 2018 17:26
This was referenced Aug 29, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@mithrav mithrav Awaiting requested review from mithrav

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @spiffxp @k8s-ci-robot