Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cherrypickunapprove for k/k #9172

Merged

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Aug 27, 2018

Bumped prow but forgot to add it to hook and do this. 🤦‍♀️
Ref: #9128

#9174 adds this new plugin into the hook binary and bumps prow.

/assign cjwagner

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2018
@nikhita nikhita force-pushed the enable-cherrypickunapprove-for-k/k branch from 5fdedac to 15785fc Compare August 27, 2018 21:35
@nikhita
Copy link
Member Author

nikhita commented Aug 27, 2018

/hold
until prow is bumped

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2018
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel
/retest

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2018
@cjwagner
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3c16889 into kubernetes:master Aug 27, 2018
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the plugins configmap using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

Bumped prow but forgot to add it to hook and do this. 🤦‍♀️
Ref: #9128

#9174 adds this new plugin into the hook binary and bumps prow.

/assign cjwagner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants