Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kind: support config files #9190

Merged
merged 4 commits into from
Aug 29, 2018
Merged

kind: support config files #9190

merged 4 commits into from
Aug 29, 2018

Conversation

BenTheElder
Copy link
Member

  • refactor config structs in cluster package, move the name to context and use config just for create
  • add functionality to load create config from file
  • add flag for config file to create cli
  • add kubeadm config template to create command

/area kind

@k8s-ci-robot k8s-ci-robot added area/kind Issues or PRs related to code in /kind cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2018
@BenTheElder
Copy link
Member Author

er need to refactor the config tests... something got lost in rebase heck there. will fix
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2018
@BenTheElder
Copy link
Member Author

/hold cancel
fixed the tests

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2018
krzyzacy
krzyzacy reviewed Aug 29, 2018
View reviewed changes
kind/pkg/cluster/cluster.go Outdated
config: config,
// similar to valid docker container names, but since we will prefix
// and suffix this name, we can relax it a little
// see Validate() for usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ source of the regex?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

krzyzacy
krzyzacy approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 29, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit d22c34f into kubernetes:master Aug 29, 2018
@BenTheElder BenTheElder deleted the konfig branch August 29, 2018 01:17
@jetstack-bot jetstack-bot mentioned this pull request Aug 29, 2018
Merged
@jetstack-bot jetstack-bot mentioned this pull request Aug 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kind Issues or PRs related to code in /kind cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @krzyzacy @k8s-ci-robot