Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blockade for KEPs (k/community) #9435

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 17, 2018

Explicit hold until kubernetes/community#2655 merges, we announce the move of KEPs to k/enhancements, and create tombstones.

/sig pm architecture
/hold

Signed-off-by: Stephen Augustus foo@agst.us

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/pm sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow labels Sep 17, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2018
@cblecker
Copy link
Member

Can we conmbine this with #9434? They conflict with each other.

@justaugustus
Copy link
Member Author

@cblecker -- I'm not sure that we're going to execute on them simultaneously, so I broke them up. Language isn't final though, so I'll update it when we decide what the flow is going to be.

@cblecker cblecker removed their request for review October 25, 2018 01:41
@justaugustus
Copy link
Member Author

justaugustus commented Nov 4, 2018

As discussed here, we plan to extract KEPs from k/community by November 30. Once that extraction is complete, this blockade should merge.

/cc: @calebamiles @jdumars

Signed-off-by: Stephen Augustus <foo@agst.us>
@cblecker
Copy link
Member

cblecker commented Dec 1, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ea1944194a49bbbe62488f3ab34b5bfa8c2a325

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2018
@justaugustus
Copy link
Member Author

For approval:
/assign @cjwagner @fejta @stevekuznetsov

@fejta
Copy link
Contributor

fejta commented Dec 1, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2018
@idealhack
Copy link
Member

As the extraction is now completed...

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@justaugustus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@justaugustus
Copy link
Member Author

This is not complete yet. We need to apply tombstones before creating the blockade: kubernetes/community#2730 (comment)

@justaugustus
Copy link
Member Author

Oh! Didn't realize you lgtm-ed the tombstone PR. Thanks @idealhack! :)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6221571 into kubernetes:master Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the plugins configmap using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

Explicit hold until kubernetes/community#2655 merges, we announce the move of KEPs to k/enhancements, and create tombstones.

/sig pm architecture
/hold

Signed-off-by: Stephen Augustus foo@agst.us

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants