Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugins for k/features and k/sig-release #9436

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Update plugins for k/features and k/sig-release #9436

merged 1 commit into from
Sep 18, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 17, 2018 •
edited
Loading

/sig pm release
/assign @idvoretskyi @calebamiles @jdumars

(some of these are plugins I'd like to have active prior to kubernetes/community#2655 flipping to implementable)

Signed-off-by: Stephen Augustus foo@agst.us

@k8s-ci-robot k8s-ci-robot added sig/pm sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/prow Issues or PRs related to prow labels Sep 17, 2018
idvoretskyi
idvoretskyi approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
cblecker
cblecker reviewed Sep 17, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise lgtm.

prow/plugins.yaml Outdated
- milestone
- override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? There isn't testing on this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Removed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2018
cjwagner
cjwagner reviewed Sep 17, 2018
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

prow/plugins.yaml Outdated
@@ -356,7 +356,11 @@ plugins:

kubernetes/features:
- approve
- blockade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no blockades (see earlier in the file) configured for this repo so this won't do anything. Did you mean to enable blunderbuss?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't blockades yet, but there will be, to prevent writes to historical dirs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added blunderbuss as well, as that will be required soon.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2018
@justaugustus
Copy link
Member Author

@cblecker @cjwagner -- rebased and addressed your comments.

@justaugustus
Update plugins for k/features and k/sig-release
1fe3b1b 
Signed-off-by: Stephen Augustus <foo@agst.us>
cblecker
cblecker approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2018
BenTheElder
BenTheElder approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, idvoretskyi, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit c00d393 into kubernetes:master Sep 18, 2018
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the plugins configmap using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

/sig pm release
/assign @idvoretskyi @calebamiles @jdumars

(some of these are plugins I'd like to have active prior to kubernetes/community#2655 flipping to implementable)

Signed-off-by: Stephen Augustus foo@agst.us

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner left review comments

@cblecker cblecker cblecker approved these changes

@BenTheElder BenTheElder BenTheElder approved these changes

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@idvoretskyi idvoretskyi

@calebamiles calebamiles

@jdumars jdumars

@cblecker cblecker

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@justaugustus @k8s-ci-robot @idvoretskyi @BenTheElder @cblecker @cjwagner @calebamiles @jdumars