-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove etcd2 from non-upgrade CI tests #9672
Conversation
This will affect the following jobs: - ci-containerd-e2e-gci-gce - ci-containerd-e2e-gci-gce-1-1 - ci-cri-containerd-e2e-gci-gce - ci-kubernetes-e2e-gci-gce - ci-kubernetes-e2e-gce-canary
This will affect the following jobs: - ci-kubernetes-e2e-gci-gce-sig-cli
This affects the following jobs: - ci-kubernetes-e2e-gci-gce-ip-alias - ci-cri-containerd-e2e-gci-gce-ip-alias
This affects the following jobs: - ci-kubernetes-e2e-gce-alpha-api
Things that are intentionally not being addressed here: $ ag '2\.2\.1|etcd2'
config/jobs/kubernetes/sig-cluster-lifecycle/sig-cluster-lifecycle-misc.yaml
24: - --upgrade_args=--ginkgo.focus=\[Feature:EtcdUpgrade\] --etcd-upgrade-storage=etcd2 --etcd-upgrade-version=2.2.1
config/jobs/kubernetes/sig-cluster-lifecycle/k8s-upgrade-gce.yaml
220: - --env=STORAGE_BACKEND=etcd2
221: - --env=ETCD_VERSION=2.2.1
222: - --env=ETCD_IMAGE=2.2.1 |
/cc @liggitt @BenTheElder |
/uncc @wojtek-t @pwittrock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
thanks Aaron!
weeeeeee /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, krzyzacy, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Scraped testgrid for the affected jobs. There are multiple dashboards for some jobs, some with regexes, some are just dupes on different dashboards. Not bothering to filter.
|
/hold cancel |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we are all agog |
Visual inspection shows no appreciable change in flakiness, no new sudden failures.
|
I'm still going to keep an eye on the ci-kubernetes-e2e-gci-gce since it's on sig-release-master-blocking, in case flakiness happens to change noticeably over the next N days. But this gives me enough confidence to move on to the upgrade tests. |
Checking back in a while later now that etcd2 code has been removed from k/k. Still no appreciable difference.
|
ref: #7602
ref: kubernetes/enhancements#622
ref: kubernetes/kubernetes#69310
I would like to address the upgrade tests in a later PR.
I've broken into commit-per-env-file, with a list of jobs
that could be impacted for each commit
/hold
I would like to get a gut check on how green these jobs are today before
we go flipping this on them. But the idea would be to merge all at once,
and then revert whichever commit(s) are necessary if jobs start failing.