- Some final fixes based on thockins comments.

kubernetes · Aug 31, 2019 · 9ac6bf0 · 9ac6bf0
1 parent d5948ec
commit 9ac6bf0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/net/net.go b/net/net.go
@@ -142,8 +142,8 @@ func ParsePort(port string, allowZero bool) (int, error) {
 	if err != nil {
 		return 0, err
 	}
-	if int(portInt) == 0 && !allowZero {
-		errors.New("Port 0 is not allowed, provide non 0 port or make allowZero true")
+	if portInt == 0 && !allowZero {
+		errors.New("0 is not a valid port number")
 	}
 	return int(portInt), nil
 }
diff --git a/net/net_test.go b/net/net_test.go
@@ -496,7 +496,6 @@ func TestParsePort(t *testing.T) {
 			name:          "zero port: allowed",
 			port:          "0",
 			allowZero:     true,
-			expectedError: false,
 		},
 		{
 			name:          "zero port: not allowed",
@@ -507,7 +506,7 @@ func TestParsePort(t *testing.T) {
 
 	for _, rt := range tests {
 		t.Run(rt.name, func(t *testing.T) {
-			actualPort, actualError := ParsePort(rt.port, allowZero)
+			actualPort, actualError := ParsePort(rt.port, rt.allowZero)
 
 			if actualError != nil && !rt.expectedError {
 				t.Errorf("%s unexpected failure: %v", rt.name, actualError)