Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tutorials/stateful-application/zookeeper/ #16618

Open
singhania opened this issue Sep 30, 2019 · 24 comments
Open

Issue with k8s.io/docs/tutorials/stateful-application/zookeeper/ #16618

singhania opened this issue Sep 30, 2019 · 24 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@singhania
Copy link

This is a Bug Report

Problem:
Solution on zookeeper on kubernetes page does not have the latest version of zookeeper.
Proposed Solution:
It will be helpful if this zookeeper deployment can use new docker with latest zookeeper version.

Page to Update:
https://kubernetes.io/docs/tutorials/stateful-application/zookeeper/

Latest

@sftim
Copy link
Contributor

sftim commented Sep 30, 2019

/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 30, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 28, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r-joyce
Copy link

r-joyce commented Mar 24, 2021

Is there any plans to still do this? The image used in the article is about 3 years old now. It's honestly a well written example in my opinion, but sucks that once it's completed to realize how old of a version it is. Also doesn't look like there's a newer image in that repository from what I can tell.

There is a more up to date version on Docker Hub which can be found here, but that is also a completely different image and requires a complete rewrite. Ideally a newer image should just be pushed, but I don't know who's in charge of that.


Edit: Link to the container registry

@sftim
Copy link
Contributor

sftim commented Mar 26, 2021

/reopen

We should still do this.
/remove-lifecycle rotten

@sftim
Copy link
Contributor

sftim commented Mar 26, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 26, 2021
@k8s-ci-robot k8s-ci-robot reopened this Mar 26, 2021
@k8s-ci-robot
Copy link
Contributor

@sftim: Reopened this issue.

In response to this:

/reopen

We should still do this.
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 26, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 24, 2021
@aravindputrevu
Copy link

aravindputrevu commented Jul 10, 2021

I was routed to here from #28837 by @sftim , I wrote a tutorial on a stateful app Elasticsearch.

It'd be great to have some stateful app tutorials on the k8s.io website as it is visited by many devs. Moreover, these are general-purpose datastores that could help many to get started with.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 9, 2021
@sftim
Copy link
Contributor

sftim commented Aug 11, 2021

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 11, 2021
@sftim
Copy link
Contributor

sftim commented Aug 11, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 11, 2021
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 8, 2023
@tengqm
Copy link
Contributor

tengqm commented Feb 8, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2023

Looks like this image was built 6 years ago and never updated.

@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2023

@Gauravpadam
Copy link
Member

Looks like this issue is still relevant, Can I work on it?

@tengqm
Copy link
Contributor

tengqm commented Oct 2, 2023

@Gauravpadam Sure you can work on it. Anyone can volunteer to contribute. Please bear in mind that we will need a working example, end to end. 3.4.10 is not too old a release for zookeeper. There is 3.9.0 on dockerhub, for example, but it doesn't mean everybody should use the latest version.
When fixing this issue, please get your hands dirty by setting up this cluster environment. There may be some tricks along the way. I heard that someone spent 2 weeks to get this up and running. Be well prepared, ;).

@Gauravpadam
Copy link
Member

Thanks for the heads up @tengqm! I'd like to try and help with this issue, Will start working on it

@bianjp
Copy link

bianjp commented Jul 10, 2024

Thanks for the heads up @tengqm! I'd like to try and help with this issue, Will start working on it

What approach would you take? Upgrading https://github.com/kow3ns/kubernetes-zookeeper/ or rewrite the tutorial to use https://hub.docker.com/_/zookeeper? It seems that kow3ns never responds to any issue or pull request.

@sftim
Copy link
Contributor

sftim commented Oct 10, 2024

/remove-lifecycle frozen

IMO: fixes are welcome, but if this rots and gets closed, that's a sign that it wasn't important to people.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 10, 2024
@bianjp
Copy link

bianjp commented Oct 11, 2024

I have made a pull request to the official zookeeper image to add custom init scripts support (31z4/zookeeper-docker#167). This will allow easier setup of myid for ZooKeeper cluster.

After that PR is accepted, I'd like to make a pull request to rewrite the tutorial to use latest official zookeeper image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: No status
Development

No branches or pull requests

10 participants