Improvement for k8s.io/docs/concepts/overview/components/

[runningman84]

the deployment controller should be mentioned in addition to the replicaset controller

[sftim]

Hi @runningman84

That list of controllers is not exhaustive (although in PR #16885 I did try to add a full list of built-in controllers).
I think it makes sense not to mention the ReplicationController controller there, for two reasons:

1. the resource is not well named
2. ReplicationController is deprecated

I suggest removing the reference to the replication controller and instead mentioning the job controller. It's just an example, and Job is a very simple control loop.

To be clear: I don't really mind what the replacement controller is; it could be the deployment controller, the job controller, or any other built-in controller.

/language en
/good-first-issue
/kind cleanup
/triage accepted

[k8s-ci-robot]

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Hi @runningman84

That list of controllers is not exhaustive (although in PR #16885 I did try to add a full list of built-in controllers).
I think it makes sense not to mention the ReplicationController controller there, for two reasons:

1. the resource is not well named
2. ReplicationController is deprecated

I suggest removing the reference to the replication controller and instead mentioning the job controller. It's just an example, and Job is a very simple control loop.

To be clear: I don't really mind what the replacement controller is; it could be the deployment controller, the job controller, or any other built-in controller.

/language en
/good-first-issue
/kind cleanup
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[slashr]

/assign

[favourch]

/assign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[favourch]

/remove-lifecycle stale

…

On Sat, Apr 24, 2021, 11:32 AM fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-contributor-experience at kubernetes/community <https://github.com/kubernetes/community>. /lifecycle stale — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#25658 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFRIUPCY3YXD7PB3S5CUKDTKKM3HANCNFSM4U5YH6DA> .

[jai]

does this refer to the section in the screenshot? If so, Replica Controller is gone:

@sftim can you confirm if I'm looking at the correct section? If so, I think this issue can be closed?

[jai]

/assign

[jai]

@runningman84 can you confirm that this issue is fixed/no long relevant?

[sftim]

/remove-lifecycle stale

[sftim]

Fixed in #25918
/close

[k8s-ci-robot]

@sftim: Closing this issue.

In response to this:

Fixed in #25918
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.