Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: update old blog post to not user "none driver" for minikube #26998

Closed
medyagh opened this issue Mar 10, 2021 · 16 comments
Closed

blog: update old blog post to not user "none driver" for minikube #26998

medyagh opened this issue Mar 10, 2021 · 16 comments
Assignees
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 10, 2021

minikube has added docker driver since 2019 and "none driver" is not recommended and only meant to be used by CI or when there is no other option. which causes issues like this for users kubernetes/minikube#8568 (comment)

we strongly suggest using other drivers. if u dont specify the --driver flag, minikube will choose the best driver for your environment.

I suggest updating this blog post to use minikube with either docker driver (or not set the --driver at all) to let minikube choose the best driver:

blog post: https://kubernetes.io/blog/2020/05/21/wsl-docker-kubernetes-on-the-windows-desktop/#minikube-updating-the-host

@idvoretskyi

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 10, 2021
@idvoretskyi
Copy link
Member

/assign

@medyagh thanks for catching this!

@idvoretskyi
Copy link
Member

/assign @nunix

@k8s-ci-robot
Copy link
Contributor

@idvoretskyi: GitHub didn't allow me to assign the following users: nunix.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @nunix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunix
Copy link

nunix commented Mar 11, 2021

first, thanks a lot for your feedback @medyagh , really appreciated.

Concerning the driver, I think the timing is very good as WSL2 is now "live", so the Windows Insiders is no more needed and the default kernel used is the 5.4.x and is built with modules needed by Kubernetes and/or Docker.

I will go through the blog post and refresh it entirely, so we keep only one blog post, but this will could be seen as a V2

@idvoretskyi
Copy link
Member

/assign @nunix

@sftim
Copy link
Contributor

sftim commented Mar 16, 2021

/sig windows
I think

@nunix we usually don't make substantial revisions to published blog articles. If you are planning a big revision, it might be better to propose a new article and then update the old article to start with a notice about reading the new article instead.
/area blog
/language en

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language labels Mar 16, 2021
@nunix
Copy link

nunix commented Mar 18, 2021

thanks a lot @sftim, I was actually start thinking the same ... but I might then just remove the part of the none driver to address this issue and then concentrate on a new blog (might take more time due to my workload lately)

@celestehorgan
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2021
@medyagh
Copy link
Member Author

medyagh commented Apr 14, 2021

@nunix I wonder was there a PR that made for this issue, is this still being worked on ?

@nunix
Copy link

nunix commented Apr 15, 2021

hi @medyagh , sorry I have some delay here. I need to test the docker provider again, my first test didn't work, but I guess I did something wrong. I will amend the blog post asap.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2021
@BioGeek
Copy link

BioGeek commented Jul 14, 2021

/remove-lifecycle stale

@nunix Can you comment if this is something you're still working on?

@sharifelgamal mentioned in issue kubernetes/minikube#10343 that proper support for WSL with the docker and none drivers is on the roadmap for this year, so maybe you're waiting on that?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 11, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

9 participants