-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner to highlight dockershim migration docs #30837
Comments
@sftim: This issue is currently awaiting triage. SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/committee steering |
Hi @kubernetes/steering-committee , just want to put this on your radar |
@sftim What's the right way to do this on the site? Is there any existing shortcode/partial for doing this? Please tag in anyone you might know that has the answer. |
@chris-short here's the PR that added a banner for KubeCon Europe 2021 |
is a months-long site-wide banner appropriate for this? |
I hadn't imagined that the banner would be shown for months. It might be ready for over a month though. I suppose I started off pessimistic that the relevant docs would be ready well before the next release. We could
|
We don't have a mechanism to mark banners as seen. Maybe it'd be useful to add one. |
Okay, so not a sitewide banner for months, check. What should the banner say? Where should it link? Found this in #31425, applicable here? Warning: This page mentions Docker Engine. Docker Engine compatibility was deprecated as of Kubernetes 1.24. For more information see [Dockershim FAQ](https://kubernetes.io/blog/2020/12/02/dockershim-faq/) |
@chris-short what #31425 suggests a notice for specific pages. This is about adding a banner (see #23183 for an example) that shows across every page of the site, during a defined period. We might want to do either or both. This suggestion, the site-wide banner, is not yet triaged as accepted. |
I'm thinking we might say “Want to know more about changes in Kubernetes v1.24 around integration with Docker Engine? Visit xxxx”. Something like that. |
Yes, I am good with the schedule and mechanics of making that happen. I was more interested in the message itself. I still think the dockershim FAQ might be the best to send folks despite it having an outdated info warning on it now. Can we turn that off for that page?!? |
@chris-short It looks like someone just put out an update of the blog: https://kubernetes.io/blog/2022/02/17/dockershim-faq/ |
That was me |
Since I took on Issue #31425 I can work on this one as well. |
I added PR #32805 to address this issue. I'm looking for feedback on wording, graphics and timeframe. |
PR #32805 merged |
@chrisnegus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen We should prepare a banner update to go live on release day. |
@sftim: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Done |
@sftim: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a Feature Request
What would you like to be added
When there are good / good-enough docs for migration away from dockershim, add a banner that highlights these docs. Leave that banner in place until (maybe even after) the v1.24 release.
Why is this needed
We're removing dockershim from Kubernetes
Comments
/sig node
/kind feature
Will need steering committee signoff
The text was updated successfully, but these errors were encountered: