Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releases page to minimum required content #31010

Closed
sftim opened this issue Dec 17, 2021 · 8 comments · Fixed by #31272
Closed

Add releases page to minimum required content #31010

sftim opened this issue Dec 17, 2021 · 8 comments · Fixed by #31272
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Dec 17, 2021

This is a Feature Request

What would you like to be added
I propose that https://kubernetes.io/docs/contribute/localization/#minimum-required-content should include https://k8s.io/releases/

Why is this needed
The releases page (just the front page, and not requiring any pages within it) is a key document to make available to readers. The shortcode this page uses already has localization support.

I think we should localize this page.

Comments
If we accept this issue, we should also open one issue per downstream localization, about making sure that that localization team works on and localizes /releases for their target localization. Link each of those issues back to this one, which then becomes an umbrella issue.

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 17, 2021
@sftim
Copy link
Contributor Author

sftim commented Dec 17, 2021

PS. The pl localization is ahead of the curve on this one, and shows an example of what success looks like.

There's one paragraph in the shortcode that doesn't yet localize; if you look at the rendered page you'll see that it's marked as English. Fixing that would be a separate issue.

@kbhawkey
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 19, 2021
@sftim
Copy link
Contributor Author

sftim commented Dec 20, 2021

/language en
/help

@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/language en
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 20, 2021
@jayesh-srivastava
Copy link
Member

Hi @sftim, if the issue is still open, can I work on it?

@anubha-v-ardhan
Copy link
Member

/assign @jayesh-srivastava
Sure

@sftim
Copy link
Contributor Author

sftim commented Jan 9, 2022

@jayesh-srivastava do you have any questions about how to get started? You're very welcome to open a pull request.

@jayesh-srivastava
Copy link
Member

@sftim Hey I made the PR, if you can review it that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants