Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with upstream Docsy #41171

Open
sftim opened this issue May 16, 2023 · 9 comments
Open

Align with upstream Docsy #41171

sftim opened this issue May 16, 2023 · 9 comments
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented May 16, 2023

This is a Feature Request

What would you like to be changed

  • Identify areas where this site has behavior different from Docsy
  • From those areas, pick a subset where the differences are either unhelpful or do not add value
  • One by one, change the site to omit those unwanted differences (adopting the behavior from upstream Docsy)

Why is this needed
We adopted Docsy, originally with a change that left the site looking similar to how it was the day before the switch.
If we can get our site closer to how Docsy usually works, it will be easier to maintain.

Comments
Inspired by #41151 (comment)

/area web-development

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label May 16, 2023
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2023
@sftim
Copy link
Contributor Author

sftim commented Nov 20, 2023

Duplicated by #44002

@reylejano
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2024
@sftim
Copy link
Contributor Author

sftim commented Feb 10, 2024

/lifecycle frozen

We'd like to ensure that this happens.

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 10, 2024
@sftim
Copy link
Contributor Author

sftim commented Apr 12, 2024

I plan to send in some PRs that lay the groundwork for this.

@chalin
Copy link
Contributor

chalin commented Nov 22, 2024

Now that #48721 for Docsy 0.3.0 has been merged, here are some relevant Docsy 0.4.0 resources:

Actually, we need to skip to 0.5.1 to be able to use Docsy via an NPM module:

@sftim
Copy link
Contributor Author

sftim commented Jan 15, 2025

Relevant to #49451

@sftim
Copy link
Contributor Author

sftim commented Jan 27, 2025

Next item (but others can land first): #48258

@seokho-son
Copy link
Member

Hi @sftim,

I have reviewed the screens from a Korean localization perspective. (reviewed on Feb. 12, 2025)

On the Korean page, there is an issue where the menu is not displayed correctly. Additionally, when resizing the window, the menu shifts, making the content inaccessible.

Image

On the English page, there is also an issue where the language selection option in the menu moves to the bottom left when the browser window is resized.

Image

You may already be aware of these issues, but I wanted to share my findings.
Apart from these, I haven’t found any other issues related to Korean localization yet.

Hope this helps!

@sftim
Copy link
Contributor Author

sftim commented Feb 12, 2025

@seokho-son can you add this comment to PR #48363 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants