Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) #49031

Open
wants to merge 2 commits into
base: release-1.31
Choose a base branch
from

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 12, 2024

Based on PR #48812 by @chalin

Also addresses and closes the following:

Previews

Checks I've done

I've checked that the following render correctly, feel free to double check:

  • Icons (now that we're using FA v6) render properly in the
    • Footer
    • Doc pages, page-meta-links section
    • Blog pages, page-meta and other links
    • More rarely used icons like the third-party icon (in page-meta), for example see Concepts > Windows
  • Mermaid diagrams continue to render correctly
  • Tooltips are still working, demonstrating that the new way to fetch and use Bootstrap CSS and JS is working
  • Code-blocks and figures render correctly

Followup changes

This PR makes minimal changes. Consider following up with updates to:

Related:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for k8s-v1-31 ready!

Name Link
🔨 Latest commit 465fe08
🔍 Latest deploy log https://app.netlify.com/sites/k8s-v1-31/deploys/675a31c0ce26e700081d03cf
😎 Deploy Preview https://deploy-preview-49031--k8s-v1-31.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor Author

sftim commented Dec 12, 2024

/hold
for PR #48812 to merge

/area web-development

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 465fe08
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/675a31c0fff5ec00084df5c7
😎 Deploy Preview https://deploy-preview-49031--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor Author

sftim commented Dec 12, 2024

Hmm. https://deploy-preview-49031--k8s-v1-31.netlify.app/community/ looks wrong and I cannot figure out why.

/retitle [WIP] Upgrade to Docsy 0.5.1 via NPM module (1.31 backport)

@k8s-ci-robot k8s-ci-robot changed the title Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) [WIP] Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants