-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use canonical FontAwesome v6 icon names, upgrading from v3-v5 #48811
Comments
/kind bug |
/priority backlog |
You won't like this @chalin but the That's the original presentation intent, so bear that in mind when considering what we'd like to preserve… |
LOL, that's good to know. Thanks for the context @sftim. I'll revert the change. |
Maybe we should add a Hugo comment to explain! |
I've recovered this behavior using |
Edit: Actually, all v3-v5 IDs should be updated to use the v6 icon's canonical name, such as the following for GitHub once Docsy is upgraded to 0.5.1+ (#48807):
Visit https://kubernetes.io/docs/concepts/windows/intro/ and you'll currently see the following page-meta links:
Notice that the
<i class="fa fa-icon-circle fa-fw"></i>
used to generate this icon doesn't render. The use of this icon was introduced via #29877, but even in that PR's preview the icon doesn't render, see: https://deploy-preview-29877--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/container-runtimes/#container-runtimesFA v3 icon!
It took some digging, but I finally found it! That is 3 major versions back 😅. It was a FA v3 icon: https://fontawesome.com/v3/icon/circle
Replacement
The replacement seems to be https://fontawesome.com/icons/circle?f=classic&s=solid:
The text was updated successfully, but these errors were encountered: