-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap and Font Awesome (as part of Docsy) are deprecated #32905
Comments
Insta-freezing this one |
/assign New to the community and would love to contribute. Am going to try building the site locally first and then … Try to change the build by bringing in Docsy as a Hugo module, using the approach outlined here in google/docsy#871 |
If you're picking this up @jasonbraganza then as well as the local dev story, you will need to tweak the live and preview publication mechanisms that are configured in |
@sftim Yes. will do so. |
just an update |
i cannot seem to make progress at this. |
/unassign |
/assign |
/triage accepted |
@sftim, if I understand correctly, we still use the git submodule way to build the site locally and via Netlify. However, the challenge is that we need to have these scripts separately installed for Netlify and local builds using this comment? I'm assuming given the timeline of this issue, we're currently not using these two. However, would having these improve the UX of our website? |
I think the way forward is to bump to a slightly newer version of Docsy - one that has good support for being imported as a Hugo module not as a Git submodule. Then, having done that bump, switch to using that support: drop the submodule, and use Docsy as a Hugo module. At that point, we then do a further small bump to the Docsy version, enough to resolve this issue. |
Also see #41171 |
That does make sense. |
Rephrasing it all for better clarity, What's the issue? Currently, the Kubernetes website uses v0.2.0 of the Docsy theme on Hugo and we import it via Git submodules during Netlify and local builds. As of v.0.4.0, the theme deprecated the import of Bootstrap & Font Awesome via Git submodules. We still need to continue using these and are running on a wildly outdated Docsy version (the latest Docsy version is v0.8.0) Proposed solution:
Does the above sound correct to you, @sftim? |
/area web-development |
For the slightly newer version, pick 0.3.x (or 0.4.0 if 0.3.x doesn't work) |
Help is still welcome. |
This is a Bug Report
Problem:
Currently, the Kubernetes website uses v0.2.0 of the Docsy theme on Hugo and we import it via Git submodules during Netlify and local builds. As of v.0.4.0, the theme deprecated the import of Bootstrap & Font Awesome via Git submodules. We still need to continue using these and are running on a wildly outdated Docsy version (the latest Docsy version is v0.8.0).
google/docsy#950 marks that within the context of the Docsy theme:
Docsy still use these things, but the recommended. mechanism for that is no longer Git submodules.
Proposed Solution:
Additional Information:
For the slightly newer version, pick 0.3.x (or 0.4.0 if 0.3.x doesn't work)
We should bump to the newest 0.4.x for fixing this issue; a separate issue tracks bumping to the very latest Docsy.
The text was updated successfully, but these errors were encountered: