Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX for code_sample shortcode #48950

Open
apoorvapendse opened this issue Dec 5, 2024 · 6 comments · May be fixed by #48958
Open

Improve UX for code_sample shortcode #48950

apoorvapendse opened this issue Dec 5, 2024 · 6 comments · May be fixed by #48958
Assignees
@apoorvapendse
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@apoorvapendse
Copy link

apoorvapendse commented Dec 5, 2024 •
edited
Loading

This is a Feature Request

What would you like to be added

modal_backdrop_ux.mp4
  • The modal's backdrop is frustrating since it blocks the rest of the content unnecessarily.
  • Instead of showing a modal on copying text which has to be closed for further usage of the website, a simple animation could be used to denote that the content has been successfully copied to the clipboard.
  • Also the placement of the link of the yaml file kept near to copy icon is confusing/inconvenient, maybe the copy icon can be placed at the bottom right corner to prevent misclicks.

Why is this needed

Better user experience, current UX is pretty annoying if you want to copy the same content over at multiple places.

Comments
@apoorvapendse apoorvapendse added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 5, 2024
@apoorvapendse apoorvapendse changed the title Replace modal with animation that doesn't occupy the Animation That Doesn't Occupy the Viewport with Its Backdrop while copying. Dec 5, 2024
@apoorvapendse apoorvapendse changed the title Animation That Doesn't Occupy the Viewport with Its Backdrop while copying. Animation that doesn't occupy the viewport with its backdrop while copying. Dec 5, 2024
@sftim
Copy link
Contributor

sftim commented Dec 5, 2024

/retitle Improve UX for code_sample shortcode
/area web-development

@k8s-ci-robot k8s-ci-robot changed the title Animation that doesn't occupy the viewport with its backdrop while copying. Improve UX for code_sample shortcode Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Dec 5, 2024
@apoorvapendse
Copy link
Author

@sftim, can I work on it?

@sftim
Copy link
Contributor

sftim commented Dec 5, 2024

can I work on it

Absolutely. Because Kubernetes is open source, you don't even need permission to start work.

@sftim sftim mentioned this issue Dec 5, 2024
Open
@apoorvapendse
Copy link
Author

/assign

apoorvapendse added a commit to apoorvapendse/website that referenced this issue Dec 6, 2024
@apoorvapendse
web: Improve UX for copyCode animation
56cc6ca 
This commit introduces a new toast animation instead
of the previous modal that would have to be manually closed.
The new toast is less intrusive to the user's workflow
and closes by itself.

Fixes kubernetes#48950.

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>
@apoorvapendse apoorvapendse linked a pull request Dec 6, 2024 that will close this issue
Open
apoorvapendse added a commit to apoorvapendse/website that referenced this issue Dec 6, 2024
@apoorvapendse
web: Improve UX for copyCode animation
3dc1438 
This commit introduces a new toast animation instead
of the previous modal that would have to be manually closed.
The new toast is less intrusive to the user's workflow
and closes by itself.

Fixes kubernetes#48950.

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>
@sftim
Copy link
Contributor

sftim commented Dec 13, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 13, 2024
@sftim
Copy link
Contributor

sftim commented Dec 13, 2024

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorvapendse apoorvapendse

Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

web: Improve UX for copyCode animation apoorvapendse/website
3 participants
@k8s-ci-robot @sftim @apoorvapendse