docs: update deprecated sample code on service/#internal-load-balancer

[dkarczmarski]

on https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer

we have a snippet for AWS:

metadata:
  name: my-service
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-internal: "true"

however, according to https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.7/guide/service/annotations it is deprecated, so maybe we should replace it with a new one:

service.beta.kubernetes.io/aws-load-balancer-scheme: "internal"

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[RajeshvShiyal]

Hello,

If this is only doc issue, then I would be happy to submit PR for same. Thanks.

cc: @dkarczmarski, @spzala

[RajeshvShiyal]

/assign @RajeshvShiyal

[dkarczmarski]

@RajeshvShiyal
please go ahead and open a PR :)

[RajeshvShiyal]

/triage accepted

[k8s-ci-robot]

@RajeshvShiyal: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to this:

/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lmktfy]

This annotation is for the in-tree implementation of Service, not for the add-on named AWS Load Balancer Controller.

So I think the existing docs may be correct.

[dkarczmarski]

This annotation is for the in-tree implementation of Service, not for the add-on named AWS Load Balancer Controller.

So I think the existing docs may be correct.

@lmktfy
if I understand it correctly, the AWS Load Balancer Controller add-on is the successor of the in-tree implementation.
in the 'contribution' chapter of the kubernetes documentation, they say that this documentation is not a place to advertise third-party solutions. but in this case, maybe it is worth noting to add some sentence that this in-tree implementation is no longer developed and that successor is the add-on.

for example, on the ingress page https://kubernetes.io/docs/concepts/services-networking/ingress/ ,
there is a sentence:

Note:
Ingress is frozen. New features are being added to the Gateway API.

maybe, we can do something similar, so we can leave it as it is, but one additional sentence about the new version would be helpful :)

[dkarczmarski]

@lmktfy
when I created this issue it had a minor priority. and when you said it's correct because it is about build-in function, not add-on, it became even less priority :) if you consider it unnecessary to update, we can close this issue.

[lmktfy]

I'll close it. The in-project implementation of Service via cloud-controller-manager is still a thing, I think. AWS Load Balancer Controller is more of an add-on.

/close not-planned

[k8s-ci-robot]

@lmktfy: Closing this issue, marking it as "Not Planned".

In response to this:

I'll close it. The in-project implementation of Service via cloud-controller-manager is still a thing, I think. AWS Load Balancer Controller is more of an add-on.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.