Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add examples using "rollout" #10583

Merged
merged 2 commits into from
Nov 19, 2018
Merged

add examples using "rollout" #10583

merged 2 commits into from
Nov 19, 2018

Conversation

anapsix
Copy link
Contributor

@anapsix anapsix commented Oct 11, 2018

since "rolling-update" is deprecated, add examples using "rollout"

since "rolling-update" is deprecated, add example using "rollout"
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0edd303

https://deploy-preview-10583--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 11, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4c58c93

https://deploy-preview-10583--kubernetes-io-master-staging.netlify.com

kubectl rolling-update frontend-v1 frontend-v2 --rollback # (deprecated) Abort existing rollout in progress
kubectl set image deployment/frontend www=image:v2 # Rolling update "www" pods of "frontend" deployment, updating the image
kubectl rollout undo deployment/frontend # Rollback to the previous deployment
kubectl rollout status -w deployment/frontend # Watch rolling update status of "frontend" deployment until completion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the deprecated commands from the new ones into a new code block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a note about the version since which the command has been deprecated would be helpful to readers.

Referenced version where `rolling-update` was deprecated
Separated `rollout` example into it's own block
@anapsix
Copy link
Contributor Author

anapsix commented Oct 12, 2018

@tengqm sure thing, updated

@tengqm
Copy link
Contributor

tengqm commented Oct 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2018
@tengqm
Copy link
Contributor

tengqm commented Oct 15, 2018

/cc @janetkuo

@k8s-ci-robot k8s-ci-robot requested a review from janetkuo October 15, 2018 01:56
@zacharysarah
Copy link
Contributor

@janetkuo 👋 Could you review this for accuracy, please? Thanks in advance!

@zacharysarah
Copy link
Contributor

/assign @janetkuo

@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8790759 into kubernetes:master Nov 19, 2018
@anapsix anapsix deleted the patch-1 branch November 19, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants