-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add examples using "rollout" #10583
add examples using "rollout" #10583
Conversation
since "rolling-update" is deprecated, add example using "rollout"
Deploy preview for kubernetes-io-master-staging ready! Built with commit 0edd303 https://deploy-preview-10583--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4c58c93 https://deploy-preview-10583--kubernetes-io-master-staging.netlify.com |
kubectl rolling-update frontend-v1 frontend-v2 --rollback # (deprecated) Abort existing rollout in progress | ||
kubectl set image deployment/frontend www=image:v2 # Rolling update "www" pods of "frontend" deployment, updating the image | ||
kubectl rollout undo deployment/frontend # Rollback to the previous deployment | ||
kubectl rollout status -w deployment/frontend # Watch rolling update status of "frontend" deployment until completion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we separate the deprecated commands from the new ones into a new code block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also a note about the version since which the command has been deprecated would be helpful to readers.
Referenced version where `rolling-update` was deprecated Separated `rollout` example into it's own block
@tengqm sure thing, updated |
/lgtm |
/cc @janetkuo |
@janetkuo 👋 Could you review this for accuracy, please? Thanks in advance! |
/assign @janetkuo |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
since "rolling-update" is deprecated, add examples using "rollout"