Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hugo in Travis CI pipeline #10606

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Use hugo in Travis CI pipeline #10606

merged 1 commit into from
Nov 19, 2018

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 13, 2018 •
edited
Loading

This PR adds into the CI pipeline to avoid unintentional regressions such as one from #10485, which was fixed at #10604.

By running hugo, we can check:

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 13, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 13, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6fd407e

https://deploy-preview-10606--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit eb2e26b

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc15f5582d3f15c9e16f96e

@tnir
Copy link
Contributor Author

tnir commented Oct 13, 2018

/kind sig/contributor-experience

/assign

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2018
@tnir tnir force-pushed the test-run-hugo branch 3 times, most recently from ae4cb7c to d5e295f Compare October 13, 2018 04:59
@tnir tnir changed the title WIP: Use hugo in Travis CI pipeline Use hugo in Travis CI pipeline Oct 13, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2018
@tnir
Copy link
Contributor Author

tnir commented Oct 15, 2018

Failure was fixed in #10610 etc.

@tnir
Copy link
Contributor Author

tnir commented Oct 15, 2018

/unassign
/assign @steveperry-53

@k8s-ci-robot k8s-ci-robot assigned steveperry-53 and unassigned tnir Oct 15, 2018
@tnir
Copy link
Contributor Author

tnir commented Oct 15, 2018

I think this is very useful for l10n owners/contributors. @gochist What do you think?

/cc @gochist

@k8s-ci-robot k8s-ci-robot requested a review from gochist October 15, 2018 01:18
tengqm
tengqm reviewed Oct 15, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@tnir
Copy link
Contributor Author

tnir commented Oct 16, 2018

@steveperry-53 Could you check if the PR can be merged?

@tnir
Use hugo in Travis CI pipeline
6fd407e 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir mentioned this pull request Oct 16, 2018
Closed
2 tasks
@zacharysarah
Copy link
Contributor

@lucperkins 👋 PTAL

/assign @lucperkins

@zacharysarah
Copy link
Contributor

/unassign @steveperry-53

@tnir
Copy link
Contributor Author

tnir commented Oct 18, 2018

Thanks, Zach, for updating the assignee 😄

@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 51c602d into kubernetes:master Nov 19, 2018
@tnir tnir deleted the test-run-hugo branch December 7, 2018 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@jimangel jimangel Awaiting requested review from jimangel

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@gochist gochist Awaiting requested review from gochist

Assignees

@lucperkins lucperkins

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tnir @k8sio-netlify-preview-bot @zacharysarah @tengqm @k8s-ci-robot @lucperkins @steveperry-53 @kubernetes-docs-i18n-bot