Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ‘rkt’ as deprecated for '--container-runtime' #10895

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Mark ‘rkt’ as deprecated for '--container-runtime' #10895

merged 1 commit into from
Nov 14, 2018

Conversation

Pingan2017
Copy link
Member

rkt is no longer supported

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2018
@Pingan2017
Copy link
Member Author

/assign @Bradamant3

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 558b74e

https://deploy-preview-10895--kubernetes-io-master-staging.netlify.com

@Pingan2017 Pingan2017 changed the title Mark ‘rkt’ as deprecated in kubelet flags(--container-runtime) Mark ‘rkt’ as deprecated for '--container-runtime' Nov 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 558b74e

https://deploy-preview-10895--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Nov 12, 2018

since which version it was removed? I did a search in the change log but failed to find an entry.

@Pingan2017
Copy link
Member Author

@tengqm
deprecated in v1.10 and unsupported iin v1.11
see:
kubernetes/kubernetes#58418
kubernetes/kubernetes#61432

@tengqm
Copy link
Contributor

tengqm commented Nov 12, 2018

@Pingan2017 Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@Bradamant3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit f15d772 into kubernetes:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

@Bradamant3 Bradamant3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pingan2017 @k8sio-netlify-preview-bot @tengqm @Bradamant3 @k8s-ci-robot